Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

grid view: automatically open the included view when clicking on a row #942

Closed
teosarca opened this issue Jun 26, 2017 · 10 comments
Closed

Comments

@teosarca
Copy link
Member

Type of issue

Feature request

Expected behavior

If configured (e.g. provided in layout),
when clicking a grid view row
then automatically open the included view in the right panel (where it's normally opened).

If you have a suggestion about how to change the protocol, it would be very nice.
If not, i will come with a proposal very soon.

@teosarca teosarca added this to the 2017-26 milestone Jun 26, 2017
@cadavre cadavre modified the milestones: 2017-26, 2017-27 Jun 26, 2017
@cadavre
Copy link
Contributor

cadavre commented Jun 26, 2017

Could you provide live example of how it works now and basically what to change?

@teosarca
Copy link
Member Author

Yup.

At the moment, the only way to open an included view is by calling a quick action which returns "instructions" about opening the included view (which one, etc)

What we need (for a new functionality we are developing) is a way to instantly open the included view when user clicks on a row from left side view (the main view).

@cadavre
Copy link
Contributor

cadavre commented Jun 27, 2017

@damianprzygodzki please provide API response example snippet to implement on backend to work with frontend.

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Jun 27, 2017

Firstly i want to highly underline, that we are talking about functionality in modal because only there includedViews are available.

GET /rest/api/documentView/{windowId}/layout

{
  ...,
  supportIncludedViewOnSelect: true
}

GET /rest/api/documentView/{windowId}/{viewId}

{
  ...,
  results: [
    {
      ...,
      includedView: {
        windowId: "",
        viewId: ""
      }
    }
  ]
}

@teosarca
Copy link
Member Author

UPDATE: implemented as suggested, API available on w101.

To test it, open https://w101.metasfresh.com:8443/window/540345 ,
select a line and then call "Pick" quick actions.
A modal it's displayed and that's the modal we are talking about.
That view has "supportIncludedViewOnSelect".

@Dunkat Dunkat self-assigned this Jul 3, 2017
@cadavre cadavre modified the milestones: 2017-27, 2017-28 Jul 4, 2017
@Dunkat
Copy link
Contributor

Dunkat commented Jul 4, 2017

to open includedView I using viewId from

{
  ...,
  results: [
    {
      ...,
      includedView: {
        windowId: "",
        viewId: ""
      }
    }
  ]
}

but always I am getting error "No view found for viewId=...". Should I use different viewId?

image

Dunkat added a commit that referenced this issue Jul 4, 2017
cadavre added a commit that referenced this issue Jul 10, 2017
grid view: automatically open the included view when clicking on a row #942
@teosarca
Copy link
Member Author

rolled to w101

@teosarca
Copy link
Member Author

found following issue, and i think it's a side effect of this task:

  • open manufacturing orders: https://w101.metasfresh.com:8443/window/53009
  • select a mfg order and call "Issue/Receipt" quick action
  • select a "CO"mponent line
    => at that moment, on the right side, some empty panel is shown but it shall not

I think, the issue was introduced in this task. If not, pls let me know and we can create a new issue.

image

Dunkat added a commit that referenced this issue Jul 13, 2017
display included view when should be displayed #942
@Dunkat
Copy link
Contributor

Dunkat commented Jul 13, 2017

it was because of this task, already fixed and pushed to master

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 14, 2017
[#998](metasfresh/metasfresh-webui-frontend-legacy#998) Picking: quick actions button not shown
[#992](metasfresh/metasfresh-webui-frontend-legacy#992) Disable quick action dropdown button while running the action
[#498](metasfresh/metasfresh-webui-api-legacy#498) Return HUs to Customer action is not working
[#1010](metasfresh/metasfresh-webui-frontend-legacy#1010) Action menu Window Name
[#978](metasfresh/metasfresh-webui-frontend-legacy#978) Make Avatar and Notifications accessible in Edit mode
[#1943](#1943) Window Business Partner Group Advanced Edit
[#501](metasfresh/metasfresh-webui-api-legacy#501) Picking prototype (v4)
[#1011](metasfresh/metasfresh-webui-frontend-legacy#1011) Checking/ unchecking flags in included tabs lead to errors in console
[#966](metasfresh/metasfresh-webui-frontend-legacy#966) sitemap: menu item incorrectly flagged as favorite in search result
[#942](metasfresh/metasfresh-webui-frontend-legacy#942) grid view: automatically open the included view when clicking on a row
[#930](metasfresh/metasfresh-webui-frontend-legacy#930) Refactor/unify Menu and Sitemap
[#836](metasfresh/metasfresh-webui-frontend-legacy#836) Outbound eMail functionality
[#495](metasfresh/metasfresh-webui-api-legacy#495) API: Functionality to add Actions for Subtab Data
[#948](metasfresh/metasfresh-webui-frontend-legacy#948) Define refactoring plan for filters model
[#891](metasfresh/metasfresh-webui-frontend-legacy#891) Blocked cells

me-45
@metas-lc metas-lc self-assigned this Jul 14, 2017
@metas-lc
Copy link

IT

  1. picking -> select a line -> pick -> select a line => right panel opens OK
  2. manufacturing order, issue/receipt -> select the product -> select the co-product => each time the right side panel looks fine OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants