Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subscription without shipment #992

Closed
metasnw opened this issue Feb 18, 2017 · 6 comments
Closed

Allow subscription without shipment #992

metasnw opened this issue Feb 18, 2017 · 6 comments

Comments

@metasnw
Copy link
Member

metasnw commented Feb 18, 2017

Today I do not have a way to define a flatrate condition that only generates invoice candidates but no shipment schedules.
For cases like memberships (´#987) there is no delivery and just the invoice candidate is needed.

Wish:
Have a contract type like "abonnement_leistung" and rename the existing into "abonnement_lieferung"

image

@metas-ts
Copy link
Member

metas-ts commented Mar 13, 2017

hi @metasnw,
is this task still up-to-date?
Asking because I think I remember you having mentioned that you somehow might have solved (or just circumvented?) the problem.
Apart from that, we might want to consider also to not introduce a new contract type, but somehow use the product types like "service"...

@metasnw
Copy link
Member Author

metasnw commented Apr 8, 2017

hi @metas-ts
that topic is still how as the workaround is to set invoice rule to immediately thus creating unnecessary shipment schedule lines.
I agree to your idea to have a product type service which implies a product which is not be shipped physically.

Any idea for an estimation to provide this feature?

@metas-ts
Copy link
Member

  • Development would be somewhere less or equal to 3hrs.
  • Plus IT (1hr?)

We already have this thing for invoice candidtes: if M_Product.ProductType is not "Item", then set the invocie rule to "Immediate". So all we need is to exclude "not-Item" products when creating shipment schedules for order lines. I'm going to do this now..it's almost quicker done than explained

metas-ts added a commit that referenced this issue Apr 10, 2017
* the main thing is the change in the view
C_OrderLine_ID_With_Missing_ShipmentSchedule_v
* minor cleanup: remove two deprecated methods from MProduct
* minor cleanup: fix method name from
IInOutCandHandler.createDeliverReques (add a 't') 

#992 Allow subscription without shipment
metas-ts added a commit that referenced this issue Apr 10, 2017
Allow subscription without shipment #992
metas-ts added a commit that referenced this issue Apr 10, 2017
[#992](#992) Allow subscription without shipment
@teosarca
Copy link
Member

So all we need is to exclude "not-Item" products when creating shipment schedules for order lines.

(not sure if we would still need it, but adding it here for reference)
If we exclude the non-Item products from shipment, because we will not be able to "ship" services, in case that's needed.
So, somehow we assume the service was delivered on invoice.

@metas-mk
Copy link
Member

metas-mk commented Apr 14, 2017

Hm, not sure about this. The workaround is ok from what I understood, but we shall set up the use cases before going further.
Generally spoken, for me, a membership can also be "delivered"/ "started" together with the shipment of the membership badge. Same for services. I can contract services, they should be in shipment shedule for the moment where I decide to do the service. Instead of an inout "shipment", i can create an inout "service hours note".

@metasnw
Copy link
Member Author

metasnw commented Apr 26, 2017

I agree that we need to look at the cases.
Becauses there are cases with subscriptions where there is really no service or product delivered for this case it would be efficient to not create shipment schedules.
But there are other cases where you want to determine the time and amount of delivery (hours, newspaper, traffic volumes).
So I am also not sure if it is a good idea to use the existing product type service.

We could link it to the flatrate condition or introduce a new product type "virtual" / "no delivery" whatever...

@metasnw metasnw closed this as completed Jun 19, 2017
metas-ts added a commit that referenced this issue Jul 14, 2017
[#998](metasfresh/metasfresh-webui-frontend-legacy#998) Picking: quick actions button not shown
[#992](metasfresh/metasfresh-webui-frontend-legacy#992) Disable quick action dropdown button while running the action
[#498](metasfresh/metasfresh-webui-api-legacy#498) Return HUs to Customer action is not working
[#1010](metasfresh/metasfresh-webui-frontend-legacy#1010) Action menu Window Name
[#978](metasfresh/metasfresh-webui-frontend-legacy#978) Make Avatar and Notifications accessible in Edit mode
[#1943](#1943) Window Business Partner Group Advanced Edit
[#501](metasfresh/metasfresh-webui-api-legacy#501) Picking prototype (v4)
[#1011](metasfresh/metasfresh-webui-frontend-legacy#1011) Checking/ unchecking flags in included tabs lead to errors in console
[#966](metasfresh/metasfresh-webui-frontend-legacy#966) sitemap: menu item incorrectly flagged as favorite in search result
[#942](metasfresh/metasfresh-webui-frontend-legacy#942) grid view: automatically open the included view when clicking on a row
[#930](metasfresh/metasfresh-webui-frontend-legacy#930) Refactor/unify Menu and Sitemap
[#836](metasfresh/metasfresh-webui-frontend-legacy#836) Outbound eMail functionality
[#495](metasfresh/metasfresh-webui-api-legacy#495) API: Functionality to add Actions for Subtab Data
[#948](metasfresh/metasfresh-webui-frontend-legacy#948) Define refactoring plan for filters model
[#891](metasfresh/metasfresh-webui-frontend-legacy#891) Blocked cells

me-45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants