Define refactoring plan for filters model

[teosarca]

Current behavior

Reading the comment from #864 (comment) it seems the filters model is broken.

Expected behavior

Define precisely what's broken and elaborate a plan to refactor/fix that.

For now, this task is about identifying the "filters model" issues and gaps and finding a plan to fix it.

[damianprzygodzki]

1. Static filters are delivered without layout. At least type of filter is part of layouting, not the data. For now method for rendering and sortin the filters uses data also to render filters. NOK.
   1.1 Additionally, filters rendered normally from layouts are generated from array. Another hardcoded difference in protocol.
2. Filters used to be allowed to be active one at a time. If there are static filters (together with others), they are served like mixed types in one array. NOK. View flickering, the static filters disappear, inconsistent inputs with state.
3. Sometimes when using the filters with static filters applied, the active filter model seems corrupted.

4. The one and only purpose data for filters is to iterate over, and find data for rendered component by layout (as in whole application). We cannot iterate over the data and render things.

---

And after all, i believe it is not a metasfresh/metasfresh-webui-frontend issue. It should be created in API repository.

[cadavre]

Plan:

1. Move away static=true filters from filters array in data response.
2. Bring "static filters" as separate component and move its info into data response array property called ?. @damianprzygodzki please provide a name. ;)
3. On clearing "static filter" – call API endpoint to recreate view disconnected from "static filter".

[damianprzygodzki]

GET /rest/api/documentView/{windowId}/{viewId}

{
  filters: [],
  firstRow: 0,
  ...,
  staticFilters: [
    {
      caption: "",
      id: ""
    },...
  ]
}

DELETE /rest/api/documentView/{windowId}/{viewId}/staticFilter/{staticFilterId}

{
  windowId: "",
  viewId: ""
}

[teosarca]

NOTE, i've changed the backend as described in the post above. It will be available on next rollout.

IMPORTANT: For the time being i am also providing the static filter as I did before (i.e. in the "filters" list, flagged with static:true). That part will be removed completely after this task will be implemented.

[teosarca]

API ready and rolled out on w101, see

• http://w101.metasfresh.com:8081/swagger-ui.html#!/view-rest-controller/getViewDataUsingGET
• http://w101.metasfresh.com:8081/swagger-ui.html#!/view-rest-controller/deleteStickyFilterUsingDELETE

[Dunkat]

@teosarca when I'm trying delete static filter, I am getting in respone two static filters, please have a look:

[teosarca]

will check

[teosarca]

rolled to w101

[metas-lc]

IT

1. go to a document which has referenced documents. E.g. Sales order
2. select a document and go to referenced documents, Open one e.g. Invoice candidates
   => notice the sticky filter (in my case for order) - the docs are filtered
3. use back and forward buttons
   => filter is still there - the docs are still filtered OK
4. select the filter
   => filter disappears and all the documents are shown (no filter is applied) OK
5. press back to have the filter again, then select the "go to default documents list" breadcrumb
   => filter disappears and all the documents are shown (no filter is applied) OK

[teosarca]

removed legacy code: metasfresh/metasfresh-webui-api-legacy@f5ca025