Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Fixes incorrect behaviour for included views and quickActions #992 #1046 #1069

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Fixes incorrect behaviour for included views and quickActions #992 #1046 #1069

merged 1 commit into from
Jul 26, 2017

Conversation

wiadev
Copy link
Contributor

@wiadev wiadev commented Jul 23, 2017

Fixes for #1046 & #992

  1. Fixes incorrect behavior for includedViews. Also fixes incorrect initial selection, excessive notifications about state updates, better handling of context (viewId, windowType etc).
  2. Fixes issues with quickActions which allows to correctly set enable/disable status, reduce number of notifications sent, correctly handle input parameters change and react appropriately, removes hacks like forced component refreshes at unpredictable moments.

@wiadev wiadev mentioned this pull request Jul 23, 2017
Open
This was referenced Jul 24, 2017
Closed
Closed
@teosarca
Copy link
Member

found some issues related to #992 . See #992 (comment)

@metas-mk metas-mk merged commit b05b361 into master Jul 26, 2017
@metas-mk metas-mk deleted the dev-1046-fix branch July 26, 2017 08:46
@metas-mk metas-mk restored the dev-1046-fix branch July 26, 2017 08:52
@metas-mk metas-mk mentioned this pull request Jul 26, 2017
Merged
@metas-mk
Copy link
Member

metas-mk commented Jul 26, 2017 •
edited
Loading

Reverted this merge w/ #1083
Thanks @wiadev for the info.

@teosarca teosarca deleted the dev-1046-fix branch July 27, 2017 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiadev @teosarca @metas-mk