Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

opening included view from action not working in picking #1046

Closed
teosarca opened this issue Jul 18, 2017 · 8 comments
Closed

opening included view from action not working in picking #1046

teosarca opened this issue Jul 18, 2017 · 8 comments

Comments

@teosarca
Copy link
Member

Steps to reproduce

  • open picking window: https://w101.metasfresh.com:8443/window/540345

  • select a row and call the pick action

  • then Pick modal pops up

  • select a line in left side grid and call the "Select HU to pick" action
    image

  • the action returns instructions to open a given included view but the frontend does not open it:
    image

Expected behavior

  • the included view is opened
  • if I click on a row on left side panel the "standard" included view is opened (exactly like it is now)
@wiadev
Copy link
Contributor

wiadev commented Jul 19, 2017

This issue has been fixed but I found another problem.

please, take a look at the following screenshots.
screen shot 2017-07-19-1
screen shot 2017-07-19-2

please check last red row in devtools (500 server error)
if pick another line (which contains value in HUCode column) - it works fine.

Seems bug on backend side

for some reason some elements have string IDs and this fails with 500 error when quickAction request sent.
do you see lines with empty HUCode ?
when you click on those - it throws server error.
I have no idea why these lines are distinct and have string IDs while others have numeric only.

I don't know whether this is a bug. But looks suspicious for me.
The only thing I can say - this is not UI side issue.
I'm getting string document ID in response from backend and trying to request quickActions for this item and it fails since it contains non-numeric ID.

@cadavre
Copy link
Contributor

cadavre commented Jul 19, 2017

@wiadev afair all IDs in metasfresh are string-based.

@wiadev
Copy link
Contributor

wiadev commented Jul 19, 2017

screen shot 2017-07-19-3
check out the above screenshot, please.
if you take a look at it, you will see that all ids are numberic but last id is string and it caused the 500 internal server error.

http://w101.metasfresh.com:8081/rest/api/documentView/540189/540189-7e5de7402e5a44f69533231a41ddfcd2/quickActions?selectedIds=HU1000100_P2005573
{
  "timestamp": 1500453431177,
  "status": 500,
  "error": "Internal Server Error",
  "exception": "org.adempiere.exceptions.AdempiereException",
  "message": "String document IDs cannot be converted to int: HU1000100_P2005573",
  "path": "/rest/api/documentView/540189/540189-7e5de7402e5a44f69533231a41ddfcd2/quickActions"
}

@teosarca
Copy link
Member Author

@wiadev yup, that's a known issue, see metasfresh/metasfresh-webui-api-legacy#496
But it shall not prevent this task.

@wiadev
Copy link
Contributor

wiadev commented Jul 19, 2017

@teosarca yes, this issue was fixed itself but while I'm working on this, I found the above error.

@teosarca
Copy link
Member Author

@wiadev yup, thanks

@teosarca
Copy link
Member Author

teosarca commented Jul 26, 2017

Found following issue: #1085 (comment)

teosarca added a commit that referenced this issue Jul 27, 2017
Fixes incorrect behavior for includedViews and quickActions #992 #1046
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 28, 2017
[#2083](#2083) Window Design WebUI: Customer Returns
[#2069](#2069) Window Design WebUI: Bill of Materials
[#2046](#2046) Window Design WebUI: Attribute Set
[#2092](#2092) Scheduler - improve error handling if AD_Role_ID can't be found
[#1046](metasfresh/metasfresh-webui-frontend-legacy#1046) opening included view from action not working in picking
[#518](metasfresh/metasfresh-webui-api-legacy#518) Picking prototype (v6)
[#1031](metasfresh/metasfresh-webui-frontend-legacy#1031) Autoselect when doubleclick on included Tab Row Field
[#2066](#2066) CRM: Businesspartner B2C Reminder Functionality
[#2067](#2067) switch between C_Order_MFGWarehouse with and without barcode
[#496](metasfresh/metasfresh-webui-api-legacy#496) String document IDs cannot be converted to int Handling Unit Editor
[#1061](metasfresh/metasfresh-webui-frontend-legacy#1061) Larger Avatar Menu Photo
[#1073](metasfresh/metasfresh-webui-frontend-legacy#1073) Bug in Advanced edit of Purchase order
[#1062](metasfresh/metasfresh-webui-frontend-legacy#1062) Avatar Foto stretches when not Square
[#1068](metasfresh/metasfresh-webui-frontend-legacy#1068) board: when there are no new cards show the empty result text/hint
[#1067](metasfresh/metasfresh-webui-frontend-legacy#1067) board: add new: don't show the loading icon after data is loaded
[#1026](metasfresh/metasfresh-webui-frontend-legacy#1026) grid: Get rid of double scrollbar
[#1027](metasfresh/metasfresh-webui-frontend-legacy#1027) line looks selected, but it's not
[#1045](metasfresh/metasfresh-webui-frontend-legacy#1045) frontend shall switch to offline mode on http 503 error
[#503](metasfresh/metasfresh-webui-api-legacy#503) Picking prototype (v5)
[#2042](#2042) Process to Update Widget Size in all child UI Elements of a System Element
[#2019](#2019) Add Widget Size to System Elements
[#516](metasfresh/metasfresh-webui-api-legacy#516) moving 1 TU from one LU to another
[#511](metasfresh/metasfresh-webui-api-legacy#511) Problems with Sales Opportunities Board
[#514](metasfresh/metasfresh-webui-api-legacy#514) Support HU transform from HU window

me-45
@metas-lc
Copy link

metas-lc commented Aug 10, 2017

IT

  1. go to picking window, select a line and Pick
    => a modal with 2 panels opens (product on left and picking on right)
  2. select open hu selection window
    => on the right side, there is a new panel to select the HUs you want to pick
  3. close this hu selection window by clicking onthe product
    => you are back on the modal from step 1
  4. click on the "open hu selection window" again
    => nothing happens NOK
    (have to check if it's task related)

EDIT: checked again and now this testcase is working!

@metas-lc metas-lc self-assigned this Aug 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants