improve logging: add_missing_translations()

metasfresh/metasfresh-webui-api-legacy#444
metasfresh · Jun 10, 2017 · 4bcb80a · 4bcb80a
1 parent 8be47f2
commit 4bcb80a
Show file tree

Hide file tree

Showing 2 changed files with 116 additions and 59 deletions.
diff --git a/...re.adempiere/migration/src/main/sql/postgresql/ddl/functions/add_missing_translations.sql b/...re.adempiere/migration/src/main/sql/postgresql/ddl/functions/add_missing_translations.sql
@@ -3,72 +3,63 @@
 -- DROP FUNCTION add_missing_translations();
 
 CREATE OR REPLACE FUNCTION add_missing_translations()
-  RETURNS void AS
+RETURNS void AS
 $BODY$
 DECLARE
-   ins        VARCHAR (2000);
-   sel        VARCHAR (2000);
-   inssel     VARCHAR (4001);
-   table_id   NUMERIC;
-   t	      RECORD;
-   c	      RECORD;
-   v_InsertCount integer;
+	ins        VARCHAR (2000);
+	sel        VARCHAR (2000);
+	inssel     VARCHAR (4001);
+	trlColumnNames VARCHAR(2000);
+	table_id   NUMERIC;
+	t	      RECORD;
+	c	      RECORD;
+	v_InsertCount integer;
+	v_TrlTablesCount integer := 0;
 BEGIN
+	FOR t IN (SELECT AD_Table_ID,
+				SUBSTR (tablename, 1, LENGTH (tablename) - 4) as TableName
+				FROM AD_TABLE
+				WHERE tablename LIKE '%_Trl' AND IsActive = 'Y' AND IsView = 'N'
+				ORDER BY TableName)
+	LOOP
+		ins := 'INSERT INTO ' || t.tablename|| '_TRL ('
+			|| 'ad_language,ad_client_id,ad_org_id,created,createdby,updated,updatedby,isactive,istranslated,'
+			|| t.tablename|| '_id';
+		sel := 'SELECT l.ad_language,t.ad_client_id,t.ad_org_id,t.created,t.createdby,t.updated,t.updatedby,t.isactive,''N'' as istranslated,'
+			|| t.tablename || '_id';
 
-   FOR t IN (SELECT ad_table_id,
-                   SUBSTR (tablename, 1, LENGTH (tablename) - 4) as tablename
-               FROM AD_TABLE
-              WHERE tablename LIKE '%_Trl' AND isactive = 'Y' AND isview = 'N'
-			  ORDER BY TableName)
-   LOOP
-      ins :=
-            'INSERT INTO '
-         || t.tablename
-         || '_TRL ('
-         || 'ad_language,ad_client_id,ad_org_id,created,createdby,updated,updatedby,isactive,istranslated,'
-         || t.tablename
-         || '_id';
-      sel :=
-            'SELECT l.ad_language,t.ad_client_id,t.ad_org_id,t.created,t.createdby,t.updated,t.updatedby,t.isactive,''N'' as istranslated,'
-         || t.tablename
-         || '_id';
+		-- Fetch AD_Table_ID
+		SELECT ad_table_id INTO table_id FROM AD_TABLE WHERE tablename = t.tablename;
 
-      SELECT ad_table_id
-        INTO table_id
-        FROM AD_TABLE
-       WHERE tablename = t.tablename;
+		-- Fetch translatable columns
+		trlColumnNames := '';
+		FOR c IN (SELECT col.columnname
+					FROM AD_COLUMN col INNER JOIN AD_TABLE tab ON (col.ad_table_id = tab.ad_table_id)
+					WHERE col.ad_table_id = table_id
+					AND col.istranslated = 'Y'
+					AND col.isactive = 'Y'
+					ORDER BY 1)
+		LOOP
+			trlColumnNames := trlColumnNames || c.ColumnName || '; ';
+			ins := TRIM (ins) || ',' || TRIM (c.columnname);
+			sel := TRIM (sel) || ',t.' || TRIM (c.columnname);
+		END LOOP;
 
-      FOR c IN (SELECT   col.columnname
-                    FROM AD_COLUMN col INNER JOIN AD_TABLE tab
-                         ON (col.ad_table_id = tab.ad_table_id)
-                   WHERE col.ad_table_id = table_id
-                     AND col.istranslated = 'Y'
-                     AND col.isactive = 'Y'
-                ORDER BY 1)
-      LOOP
-         ins := TRIM (ins) || ',' || TRIM (c.columnname);
-         sel := TRIM (sel) || ',t.' || TRIM (c.columnname);
-      END LOOP;
-
-      ins := TRIM (ins) || ')';
-      sel :=
-            TRIM (sel)
-         || ' from '
-         || t.tablename
-         || ' t, ad_language l WHERE l.issystemlanguage=''Y'' AND NOT EXISTS (SELECT 1 FROM '
-         || t.tablename
-         || '_TRL b WHERE b.'
-         || t.tablename
-         || '_id=t.'
-         || t.tablename
-         || '_id AND b.AD_LANGUAGE=l.AD_LANGUAGE)';
-      inssel := TRIM (ins) || ' ' || TRIM (sel);
-
-      EXECUTE inssel;
-	  GET DIAGNOSTICS v_InsertCount = ROW_COUNT;
-	  raise notice 'Inserted % rows into %_Trl', v_InsertCount, t.tablename;
-   END LOOP;
+		ins := TRIM (ins) || ')';
+		sel := TRIM (sel)
+			|| ' from ' || t.tablename || ' t, ad_language l '
+			|| ' WHERE l.issystemlanguage=''Y'''
+			|| ' AND NOT EXISTS (SELECT 1 FROM ' || t.tablename || '_TRL b WHERE b.' || t.tablename || '_id=t.' || t.tablename || '_id AND b.AD_LANGUAGE=l.AD_LANGUAGE)';
+		inssel := TRIM (ins) || ' ' || TRIM (sel);
 
+		EXECUTE inssel;
+		v_TrlTablesCount := v_TrlTablesCount + 1;
+
+		GET DIAGNOSTICS v_InsertCount = ROW_COUNT;
+		raise notice 'Inserted % rows into %_Trl (%)', v_InsertCount, t.tablename, trlColumnNames;
+	END LOOP;
+
+	raise notice 'Done. Checked/Updated % translation tables', v_TrlTablesCount;
 END;
 $BODY$
 LANGUAGE plpgsql VOLATILE

diff --git a/...stgresql/system/10-de.metas.adempiere/5464710_sys_gh444webui_add_missing_translations.sql b/...stgresql/system/10-de.metas.adempiere/5464710_sys_gh444webui_add_missing_translations.sql
@@ -0,0 +1,66 @@
+-- Function: add_missing_translations()
+
+-- DROP FUNCTION add_missing_translations();
+
+CREATE OR REPLACE FUNCTION add_missing_translations()
+RETURNS void AS
+$BODY$
+DECLARE
+	ins        VARCHAR (2000);
+	sel        VARCHAR (2000);
+	inssel     VARCHAR (4001);
+	trlColumnNames VARCHAR(2000);
+	table_id   NUMERIC;
+	t	      RECORD;
+	c	      RECORD;
+	v_InsertCount integer;
+	v_TrlTablesCount integer := 0;
+BEGIN
+	FOR t IN (SELECT AD_Table_ID,
+				SUBSTR (tablename, 1, LENGTH (tablename) - 4) as TableName
+				FROM AD_TABLE
+				WHERE tablename LIKE '%_Trl' AND IsActive = 'Y' AND IsView = 'N'
+				ORDER BY TableName)
+	LOOP
+		ins := 'INSERT INTO ' || t.tablename|| '_TRL ('
+			|| 'ad_language,ad_client_id,ad_org_id,created,createdby,updated,updatedby,isactive,istranslated,'
+			|| t.tablename|| '_id';
+		sel := 'SELECT l.ad_language,t.ad_client_id,t.ad_org_id,t.created,t.createdby,t.updated,t.updatedby,t.isactive,''N'' as istranslated,'
+			|| t.tablename || '_id';
+
+		-- Fetch AD_Table_ID
+		SELECT ad_table_id INTO table_id FROM AD_TABLE WHERE tablename = t.tablename;
+
+		-- Fetch translatable columns
+		trlColumnNames := '';
+		FOR c IN (SELECT col.columnname
+					FROM AD_COLUMN col INNER JOIN AD_TABLE tab ON (col.ad_table_id = tab.ad_table_id)
+					WHERE col.ad_table_id = table_id
+					AND col.istranslated = 'Y'
+					AND col.isactive = 'Y'
+					ORDER BY 1)
+		LOOP
+			trlColumnNames := trlColumnNames || c.ColumnName || '; ';
+			ins := TRIM (ins) || ',' || TRIM (c.columnname);
+			sel := TRIM (sel) || ',t.' || TRIM (c.columnname);
+		END LOOP;
+
+		ins := TRIM (ins) || ')';
+		sel := TRIM (sel)
+			|| ' from ' || t.tablename || ' t, ad_language l '
+			|| ' WHERE l.issystemlanguage=''Y'''
+			|| ' AND NOT EXISTS (SELECT 1 FROM ' || t.tablename || '_TRL b WHERE b.' || t.tablename || '_id=t.' || t.tablename || '_id AND b.AD_LANGUAGE=l.AD_LANGUAGE)';
+		inssel := TRIM (ins) || ' ' || TRIM (sel);
+
+		EXECUTE inssel;
+		v_TrlTablesCount := v_TrlTablesCount + 1;
+
+		GET DIAGNOSTICS v_InsertCount = ROW_COUNT;
+		raise notice 'Inserted % rows into %_Trl (%)', v_InsertCount, t.tablename, trlColumnNames;
+	END LOOP;
+
+	raise notice 'Done. Checked/Updated % translation tables', v_TrlTablesCount;
+END;
+$BODY$
+LANGUAGE plpgsql VOLATILE
+COST 100;