Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M_ShipmentSchedule_EnqueueSelection ignores role's org access #1348

Closed
metas-ts opened this issue Apr 20, 2017 · 1 comment
Closed

M_ShipmentSchedule_EnqueueSelection ignores role's org access #1348

metas-ts opened this issue Apr 20, 2017 · 1 comment
Assignees
@metas-ts @metas-dh
Labels
branch:release bug_please_use_type:bug_instead type:bug

Comments

@metas-ts
Copy link
Member

Is this a bug or feature request?

Bug

Suggestion: add the role access in processInfo.getQueryFilter
@metas-ts metas-ts self-assigned this Apr 20, 2017
metas-ts added a commit that referenced this issue Apr 20, 2017
@metas-ts
Fix ProcessInfo now returns a filter with org-restriction
eb3b072 
M_ShipmentSchedule_EnqueueSelection ignores role's org access
#1348
metas-ts added a commit that referenced this issue Apr 20, 2017
@metas-ts
Bug fix and pass null instead of getTableNameOrNull()
66977e9 
..to reduce FUD and  show that "null" is OK here :-)

M_ShipmentSchedule_EnqueueSelection ignores role's org access
#1348
metas-ts added a commit that referenced this issue Apr 20, 2017
@metas-ts
Fix ProcessInfo now returns a filter with org-restriction
fdd6ba1 
M_ShipmentSchedule_EnqueueSelection ignores role's org access
#1348
metas-ts added a commit that referenced this issue Apr 20, 2017
@metas-ts
Bug fix and pass null instead of getTableNameOrNull()
726eeeb 
..to reduce FUD and  show that "null" is OK here :-)

M_ShipmentSchedule_EnqueueSelection ignores role's org access
#1348
@metas-dh metas-dh self-assigned this Apr 26, 2017
@metas-dh
Copy link
Member

Results of IT1
tested on Swing

  • Create several sales orders, for different orgs I & II, as Admin (select Org I when logging in)
  • Log in in another session, with a different role, that has access to only Org II (Handel or Spedition)
  • Search for the M_ShipmentSchedule created for the day of test: only the ones for Org II are displayed, OK
  • Gear, Auswahl liefern: shipments for the M_ShipmentSchedules of the resp. org only are created, OK
  • Check in the Admin session: the M_ShipmentSchedules for the sales order of Org I are not changed, can still be shipped: OK
  • Log in in another session, with a different role, that has access to only Org I (Handel or Spedition)
  • Search for the M_ShipmentSchedule created for the day of test: only the ones for Org I are displayed, OK
  • Gear, Auswahl liefern: shipments for the M_ShipmentSchedules of the resp. org only are created, OK
  • Check in the Admin session: all M_ShipmentSchedules are shipped: OK
  • Delete the first shipment for Org II, and ship them as Admin (logged in with Org I): working fine, OK

metas-ts added a commit that referenced this issue Apr 28, 2017
@metas-ts
Update ReleaseNotes.md
6872bbb 
[#1348](#1348) M_ShipmentSchedule_EnqueueSelection ignores role's org access
metas-ts added a commit that referenced this issue May 2, 2017
@metas-ts
Fix ProcessInfo now returns a filter with org-restriction
b9c0050 
M_ShipmentSchedule_EnqueueSelection ignores role's org access
#1348
(cherry picked from commit eb3b072)
metas-ts added a commit that referenced this issue May 2, 2017
@metas-ts
Bug fix and pass null instead of getTableNameOrNull()
d47721e 
..to reduce FUD and  show that "null" is OK here :-)

M_ShipmentSchedule_EnqueueSelection ignores role's org access
#1348
(cherry picked from commit 66977e9)
@metas-ts metas-ts mentioned this issue May 3, 2017
Closed
metas-ts pushed a commit that referenced this issue Apr 4, 2020
@TheBestPessimist @metas-ts
Bank Statement Import directly in Bank Statement window (#1348)
8315c71 
* Ping teo for more work

#6061

* Add first draft of C_BankStatement_AllocateInvoice process and sql

#6061

* Refactoring

#6061

* Extract defaultInvoiceLookupProvider to own service

#6061

* Make `LookupDataSource.findByIdsOrdered` stable

It respects the order of the items in the input collection

#6061

* Create the payment with dates = statementLineDate

#6061

* Exclude payment if it is reconciled from allocating to a BankStatementLine

#6061

* Refactoring: Extract the logic regarding Payment selection and allocation from process to separate classes

#6061

* Refactoring: dont use list if we only expect a single param

#6061

* Add first test draft; refactor methods for easier testing

#6061

* Test refactoring
Add test for Outbound BankStatementLine

#6061

* Handle the case where no Invoice is selected; disable old case for multiple invoices until clarification with mark

#6061

* Refactor test

#6061

* Add test for BankStatement completion

Refactor classes around

#6061

* Add process `C_BankStatement_AddBpartnerAndPayment`

#6061

* Simplify `paymentLookupProvider`

#6061

* Seems like I cant `Just DO IT!`. It was too good to be true anyway :(

#6061

* Refactor: Use Money instead of BigDecimal/Currency pair

#6061

* nullcheck

#6061

* Add process C_BankStatementLine_AllocatePayment

#6061

* Process refresh bugfix

#6061

* Update trl

#6061

* Rename process

#6061

* Move method to `IBankStatmentPaymentBL` from `BankStatementBL`

#6061

* Bugfix: forgot to save bpartner

#6061

* Throw exception if no b Bank Account exists

#6061
(cherry picked from commit 4be8f09)
dragospodariu96 pushed a commit that referenced this issue May 4, 2020
@TheBestPessimist
Bank Statement Import directly in Bank Statement window (#1348)
4be8f09 
* Ping teo for more work

#6061

* Add first draft of C_BankStatement_AllocateInvoice process and sql

#6061

* Refactoring

#6061

* Extract defaultInvoiceLookupProvider to own service

#6061

* Make `LookupDataSource.findByIdsOrdered` stable

It respects the order of the items in the input collection

#6061

* Create the payment with dates = statementLineDate

#6061

* Exclude payment if it is reconciled from allocating to a BankStatementLine

#6061

* Refactoring: Extract the logic regarding Payment selection and allocation from process to separate classes

#6061

* Refactoring: dont use list if we only expect a single param

#6061

* Add first test draft; refactor methods for easier testing

#6061

* Test refactoring
Add test for Outbound BankStatementLine

#6061

* Handle the case where no Invoice is selected; disable old case for multiple invoices until clarification with mark

#6061

* Refactor test

#6061

* Add test for BankStatement completion

Refactor classes around

#6061

* Add process `C_BankStatement_AddBpartnerAndPayment`

#6061

* Simplify `paymentLookupProvider`

#6061

* Seems like I cant `Just DO IT!`. It was too good to be true anyway :(

#6061

* Refactor: Use Money instead of BigDecimal/Currency pair

#6061

* nullcheck

#6061

* Add process C_BankStatementLine_AllocatePayment

#6061

* Process refresh bugfix

#6061

* Update trl

#6061

* Rename process

#6061

* Move method to `IBankStatmentPaymentBL` from `BankStatementBL`

#6061

* Bugfix: forgot to save bpartner

#6061

* Throw exception if no b Bank Account exists

#6061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-ts metas-ts

@metas-dh metas-dh

Labels
branch:release bug_please_use_type:bug_instead type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metas-ts @metas-dh