Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop out old code related to confirm splitting when printing #2897

Closed
cristinamghita opened this issue Nov 2, 2017 · 1 comment
Closed

Drop out old code related to confirm splitting when printing #2897

cristinamghita opened this issue Nov 2, 2017 · 1 comment
Assignees
@metas-lc
Labels
branch:release bug_please_use_type:bug_instead type:enhancement

Comments

@cristinamghita
Copy link
Member

Is this a bug or feature request?

FR

What is the current behavior?

  • asking for confirmation when printing

Which are the steps to reproduce?

Try to print in the next conditions:

  • sys config de.metas.printing.MaxLinesPerJob has value 100
  • then print 102 invoices
  • in webui, the printing will fail
  • in swing is fine, and after 100 records will ask if you want to continue

What is the expected or desired behavior?

  • We don't want any user confirmation
@cristinamghita cristinamghita self-assigned this Nov 2, 2017
cristinamghita added a commit that referenced this issue Nov 2, 2017
@cristinamghita
#2897 Drop the printing monitor and reafactor a bit
e0231c0 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 2, 2017
@cristinamghita
#2897 Set by default UserOK on Y
218f148 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 2, 2017
@cristinamghita
#2897 Delete user confirmation tests
7fa806e 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 3, 2017
@cristinamghita
#2897 Add a splitting test
ad765ef 
#2897 Drop out old code related to confirm splitting when printing
@cristinamghita cristinamghita mentioned this issue Nov 3, 2017
Merged
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Rename method
a3f6d92 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Drop column UserOK
1ca84ee 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Introduce PrintJobContext
dc4aa21 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Refactor method
8f901b4 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Minor
ee90948 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Refactor a bit and use lamdas
25d95f2 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Extract code for creating C_PrintJob
4fd7ec0 
#2897 Drop out old code related to confirm splitting when printing
cristinamghita added a commit that referenced this issue Nov 7, 2017
@cristinamghita
#2897 Extrtact creating instructions
e43b1e1 
#2897 Drop out old code related to confirm splitting when printing
metas-ts added a commit that referenced this issue Nov 8, 2017
@metas-ts
hopefully improve the code
01fddb2 
* implement the trivial createPrintJobs method as **default** method
directly in IPrintJobBL
* declare PrintJobcontext not in "private" impl package but in public
IPrintJobBL (the best practice is to consider impl a private package)
* simplify the finally-block in PrintJobBL.createPrintJobs using
@default in the context class
  * also avoid passing a null context instance
* use the context class in 
* rename PrintJobcontext to ContextForAsyncProcessing

Drop out old code related to confirm splitting when printing #2897
metas-ts added a commit that referenced this issue Nov 8, 2017
@metas-ts
Merge pull request #2904 from metasfresh/gh2897
f7f7e91 
#2897 Drop out old code related to confirm splitting when printing
metas-mk added a commit that referenced this issue Nov 11, 2017
@metas-mk
Update ReleaseNotes.md
5c8b0e9 
Adding ReleaseNotes for
#2920 Create automated
test for extending contracts.
#2936) Creating new
flatrate condition and transition with autoextension became very tricky
#2894) Sys Config to set
Waiting Time for Async
#2897) Drop out old code
related to confirm splitting when printing
@metas-lc metas-lc self-assigned this Dec 20, 2017
@metas-lc
Copy link
Contributor

metas-lc commented Jan 9, 2018

IT
made config for printing pdf
set de.metas.printing.MaxLinesPerJob on 2
created and completed 5 invoices
went to Druck Warteschlange - gear - alle drucken
=> got 3 notifications OK
opened each notification - gear - PDF offen
=> 2 had 2 invoices and 1 only 1 OK

@metas-lc metas-lc closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-lc metas-lc

Labels
branch:release bug_please_use_type:bug_instead type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metas-ts @cristinamghita @metas-lc