Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prospect is converted to customer when completing a quotation #3667

Closed
metasnw opened this issue Mar 12, 2018 · 3 comments
Closed

prospect is converted to customer when completing a quotation #3667

metasnw opened this issue Mar 12, 2018 · 3 comments
Assignees
@metas-lc
Labels
branch:release bug_please_use_type:bug_instead type:enhancement

Comments

@metasnw
Copy link
Member

metasnw commented Mar 12, 2018

Is this a bug or feature request?

FR

What is the current behavior?

when you got a partner with isprospect = Y and customer = N
and complete a quotation then automatically its becoming isprospect = N and iscustomer =Y

Which are the steps to reproduce?

What is the expected or desired behavior?

apply that logic only on sales order
@metas-ts
Copy link
Member

The problem happens in /de.metas.swat.base/src/main/java/de/metas/adempiere/modelvalidator/Order.java

@metas-rc metas-rc self-assigned this Mar 12, 2018
metas-rc added a commit that referenced this issue Mar 12, 2018
@metas-rc
#3667 isprospect converted to iscustomer when completing a quotation …
446c1d6 
…on for Sales Order

#3667
metas-rc added a commit that referenced this issue Mar 12, 2018
@metas-rc
#3667 Logic for deciding when to transform prospect into customer
d2e55fe 
#3667
@metas-rc metas-rc mentioned this issue Mar 12, 2018
Merged
metas-ts pushed a commit that referenced this issue Mar 13, 2018
@metas-rc @metas-ts
#3667 isprospect converted to iscustomer when completing a quotation …
bb53a38 
…on for Sales Order

#3667
(cherry picked from commit 446c1d6)
metas-ts pushed a commit that referenced this issue Mar 13, 2018
@metas-rc @metas-ts
#3667 Logic for deciding when to transform prospect into customer
ad22873 
#3667
(cherry picked from commit d2e55fe)
@metas-ts
Copy link
Member

🍒 to release

@metas-ts metas-ts changed the title isprospect is converted to iscustomer when completing a quotation prospect is converted to customer when completing a quotation Mar 13, 2018
metas-ts added a commit that referenced this issue Mar 13, 2018
@metas-ts
Update ReleaseNotes.md
de57dea 
[#3667](#3667) prospect is converted to customer when completing a quotation
@metas-rc metas-rc removed their assignment Mar 13, 2018
@metas-lc metas-lc self-assigned this Mar 14, 2018
@metas-lc
Copy link
Contributor

  1. create a quotation for a bpartner that has isprospect = Y and iscustomer = N
    => isprospect and iscustomer did not change OK
    (isprospect is not displayed, and you cannot create a sales order with a bpartner that has iscustomer = N)
  2. create a prospect for a bpartner that has isprospect = Y and iscustomer = N
    => isprospect and iscustomer did not change OK
  3. create a sales order for a bpartner that has isprospect = Y and iscustomer = N
    => isprospect and iscustomer changed: isprospect = 'N' iscustomer = 'Y' and OK

Regression:

  1. Create a purchase order for a bpartner that has isprospect = Y and iscustomer = N
    => isprospect and iscustomer did not change OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-lc metas-lc

Labels
branch:release bug_please_use_type:bug_instead type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@metas-ts @metas-rc @metas-lc @metasnw