Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864

Closed
metas-ts opened this issue Apr 16, 2018 · 2 comments
Closed

C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864

metas-ts opened this issue Apr 16, 2018 · 2 comments
Assignees
@metas-ts @metas-dh
Labels
branch:release bug_please_use_type:bug_instead type:bug

Comments

@metas-ts
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?
@metas-ts metas-ts self-assigned this Apr 16, 2018
@metas-ts metas-ts changed the title C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is excended C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended Apr 17, 2018
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
#3864-app - solve the issue and do some refactoring
43cdbe4 
FlatrateBL: propagate C_Currency_ID when extending a term
IDocTypeDAO: change and rename getDocTypeOrNull to also support uses where we don't want null
HUInOutBL: refactor to remove some duplicated code about creating DocTypeQueries

C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
@metas-ts metas-ts mentioned this issue Apr 17, 2018
Merged
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
Avoid unnecessary if..then..else statement
021e744 
thx codacy
C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
minor comment fix
173d791 
C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
related fix: EventSource shall ignore inactive records
5e46604 
C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
@metas-ts metas-ts mentioned this issue Apr 17, 2018
Closed
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
avoid loading C_DocType and remove some more code
34c45c6 
thx @teosarca for the hint
C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
more refactoring
8ca503a 
IDocTypeDAO.queryMatchesDocTypeId; reduce needless coupling and make the method more flexible (e.g. in case aC_DocType_Target_ID needs to be matched)
C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
metas-ts added a commit that referenced this issue Apr 17, 2018
@metas-ts
Merge pull request #3867 from metasfresh/gh3864-app
e67586f 
#3864-app - solve the issue and do some refactoring
@metas-dh metas-dh self-assigned this Apr 18, 2018
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

C_FlatrateTerm.C_Currency is forwarded when a flatrateTerm is extended:

  • tested for flatrateterm type Abonnement: OK
  • tested for flatrateterm type Procurement: OK

(checked manua extension, will check automatic extension as well)

@metas-dh
Copy link
Member

Update:

  • automatic extension worked fine as well, currency was forwarded: OK

metas-ts added a commit that referenced this issue Apr 23, 2018
@metas-ts
Update ReleaseNotes.md
1259a36 
[#3892](#3892) Contracts: Allow possibility to copy the prices when extending
[#3478](#3478) Window design: product Pharma
[#3883](#3883) Cannot import products
[#3895](#3895) extend M_HU_Process
[#3897](#3897) Add Translations for Pharma Business Partner Window
[#3890](#3890) Role Permission for Pharma Permission and Authorization changes
[#3887](#3887) Automatic Setting of Pharma Authorisation for Shipment/ Receipt
[#3885](#3885) Process C_Flatrate_Term_Extend does not work if ContractStatus is null
[#3768](#3768) Excel Report for vendor assessment
[#3864](#3864) C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended
[#3876](#3876) Different issues around invoice candidate updating
[#3834](#3834) Check if Product is banned in Batch entry/ Document Lines creation
[#3763](#3763) Contracts: Create a function that provides a hierarchy of contracts
[#3863](#3863) Missing migration of C_BPartner_Stats.SOCreditStatus on some systems
[#3827](#3827) Support SSL / TLS when sending mails via SMTP making it SMTPS
[#3777](#3777) Show available to promise in Procurement Dispo modal in Sales Order
[#34](metasfresh/metasfresh-docker#34) add msv3server to metasfresh-docker as "extras"
[#3861](#3861) StockChangedEvent can't be serialized
[#3859](#3859) Credit Limit: Prioritize by date and then seq No from Credit Limit type
metas-ts added a commit that referenced this issue Apr 23, 2018
@metas-ts
apply only the actual fix from the master branch
91e69e0 
apply one line from commit 43cdbe4
C_FlatrateTerm.C_Currency is not forwarded when a flatrateTerm is extended #3864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-ts metas-ts

@metas-dh metas-dh

Labels
branch:release bug_please_use_type:bug_instead type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metas-ts @metas-dh