Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel Export and SQL for Product Specifications #4582

Closed
cristinamghita opened this issue Sep 12, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@cristinamghita
Copy link
Member

commented Sep 12, 2018

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

@cristinamghita cristinamghita self-assigned this Sep 12, 2018

cristinamghita added a commit that referenced this issue Sep 12, 2018

#4582 Add new fields in M_Product
#4582 Excel Export and SQL for Product Specifications

cristinamghita added a commit that referenced this issue Sep 12, 2018

#4582 Add view for product specifications
#4582 Excel Export and SQL for Product Specifications

cristinamghita added a commit that referenced this issue Sep 12, 2018

#4582 Add process for exporting data to csv file
#4582 Excel Export and SQL for Product Specifications
@cristinamghita

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

Dev test

  • The process can be run from product window and is run for all products
    image

  • The file resulted from looks like the one from the image below.
    image

cristinamghita added a commit that referenced this issue Sep 17, 2018

#4582 use msgBL.translate(
#4582 Excel Export and SQL for Product Specifications

cristinamghita added a commit that referenced this issue Sep 17, 2018

#4582 Retrieve country
#4582 Excel Export and SQL for Product Specifications

cristinamghita added a commit that referenced this issue Sep 17, 2018

#4582 Take corectlly the country
#4582 Excel Export and SQL for Product Specifications

metas-ts added a commit that referenced this issue Sep 18, 2018

Merge pull request #4583 from metasfresh/gh4582
#4582 Excel Export and SQL for Product Specifications

@metas-ts metas-ts added the bug label Sep 18, 2018

@metas-mk

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

@cristinamghita The Dev Test Screenshot of Excel File looks a bit corrupted
image

image

Can you please check?

@cristinamghita

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2018

@metas-mk , I broke the file when cleaned.
image

metas-ts added a commit that referenced this issue Sep 24, 2018

update ReleaseNotes.md
[#4619](#4619) de.metas.util - Rename packages to de.metas.util
[#4599](#4599) Error when posting a zero-sum invoice
[#4610](#4610) Billto Location and contact override in invoicecandidates
[#1049](metasfresh/metasfresh-webui-api#1049) Pipes/Cabling quick input shall not display the BOM products
[#1051](metasfresh/metasfresh-webui-api#1051) New Org cannot be created anymore
[#4582](#4582) Excel Export and SQL for Product Specifications
[#4601](#4601) Allow activating spring profiles via AD_SysConfig
@metas-rc

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

Results of IT:

OK: The file no longer contains corrupted data

NOK: Please, make the file .xls, not .csv

@cristinamghita

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2018

Follow up in #4648

cristinamghita added a commit that referenced this issue Oct 18, 2018

#4582 Fix type csv as MimeType
#4582 Excel Export and SQL for Product Specifications

cristinamghita added a commit that referenced this issue Oct 18, 2018

#4582 Make export work for webui and swing in same time
#4582 Excel Export and SQL for Product Specifications

cristinamghita added a commit that referenced this issue Oct 18, 2018

#4582 Show fields
#4582 Excel Export and SQL for Product Specifications

metas-ts added a commit that referenced this issue Oct 18, 2018

Merge pull request #4674 from metasfresh/gh4582_1
#4582 Excel Export and SQL for Product Specifications

@metas-ts metas-ts reopened this Oct 18, 2018

cristinamghita added a commit to metasfresh/metasfresh-webui-api that referenced this issue Oct 22, 2018

#4582 remove unnecessary dot
#4582 Excel Export and SQL for Product Specifications
metasfresh/metasfresh#4582
@metas-dh

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

Results of IT2
tested in mf15

  1. Excel export running in Swing as well: OK
  2. export results the same from Swing and Excel:
  • numbers in Swing were missing decimal dot, e.g. net weight: NOK

WebUI:
2018-10-24 12_03_32-productspecificationd_20181024 csv - libreoffice calc

Swing:
2018-10-24 12_03_59-decloudit001

  • Fields were all the same size, therefore names were often cut off in Swing export: NOK imho
    2018-10-24 12_08_36-decloudit001

cristinamghita added a commit that referenced this issue Nov 13, 2018

#4582 Implemented exporting product specifications to excel file
#4582 Excel Export and SQL for Product Specifications

metas-ts added a commit that referenced this issue Nov 16, 2018

Merge pull request #4755 from metasfresh/gh4582-app
#4582 Implemented exporting product specifications to excel file
@cristinamghita

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2018

Dev test

Swing test

  • Run process "Export product specificatins" from product window
    • And the result is an xls file that looks like this:
      image

Web test

  • Run process "Export product specificatins" from product window
    • And the result is an xls file that looks like this:
      image

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Add new fields in M_Product
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 2853ab9)

solved Conflicts:
	de.metas.adempiere.adempiere/base/src/main/java-gen/org/compiere/model/I_M_Product.java
	de.metas.adempiere.adempiere/base/src/main/java-gen/org/compiere/model/X_M_Product.java

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Add view for product specifications
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit c2bea96)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Add process for exporting data to csv file
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 55ea5a5)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 use msgBL.translate(
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 847b67d)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Retrieve country
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 117da8e)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Take corectlly the country
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 3830708)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Fix type csv as MimeType
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 0aabc1e)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Make export work for webui and swing in same time
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 48f888c)

solved Conflicts:
	de.metas.fresh/de.metas.fresh.base/src/main/java/de/metas/fresh/product/process/ExportProductSpecifications.java

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Show fields
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 3c5e424)

metas-ts added a commit that referenced this issue Dec 4, 2018

#4582 Implemented exporting product specifications to excel file
#4582 Excel Export and SQL for Product Specifications

(cherry picked from commit 84c6fc7)

solved Conflicts:
	de.metas.adempiere.adempiere/base/src/main/java-legacy/de/metas/impexp/excel/AbstractExcelExporter.java
	de.metas.adempiere.adempiere/base/src/main/java-legacy/de/metas/impexp/excel/ArrayExcelExporter.java
	de.metas.fresh/de.metas.fresh.base/src/main/java/de/metas/fresh/product/process/ExportProductSpecifications.java
@metas-dh

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Results of IT3
tested in mf15

  1. Excel export running in Swing as well: OK
  2. export results the same from Swing and Excel:
  • numbers in Swing not missing decimal dot anymore: OK
  • field size is adapted to length of value, no more cut offs in Swing export: OK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.