Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Migration for Data Entry #5257

Open
metas-ts opened this issue May 31, 2019 · 1 comment
Open

Data Migration for Data Entry #5257

metas-ts opened this issue May 31, 2019 · 1 comment
Labels
branch:master branch:release topic:DataEntry type:enhancement

Comments

@metas-ts
Copy link
Member

Is this a bug or feature request?

FR

What is the current behavior?

DataEnty data can be entered via the UI

What is the expected or desired behavior?

There should be an import process for data-entry data

Rough concept

  • Use our existing import framework (import processor implementation, I_DataEntry_Record table)
  • It's only about data-entry records; not the data-entry layout
  • so the import process needs to look up (unless ofc they are directly imported)
    • AD_Window_ID - or lookup via InternalName
    • Record_ID - lookup via ExternalId (if exists) or Value (if exists)
    • AD_Table_ID - lookup by finding the window's "main tab's" AD_Table_ID
    • DataEntry_Subtab_ID - lookup via name
    • DataEntry_Field_ID - lookup via Name
  • in addition to these, the import table needs to contain
    • field type
    • ...consider to have one "typed" field value column (FieldValueString, FieldValueNumber etc) for each value type
  • When doing the actual import, aggregate the I_DataEntry_Record records by I_DataEntry_Subtab_ID, create one de.metas.dataentry.data.DataEntryRecord instance per sub-tab-id and store them via the DataEntryRecordRepository
teosarca added a commit that referenced this issue Jun 13, 2019
@teosarca
Update AD_Column.java
18abf3e 
recognize Number fields

#5257
teosarca added a commit that referenced this issue Jun 13, 2019
@teosarca
prototyping
1c86f30 
#5257
@teosarca teosarca mentioned this issue Jun 13, 2019
Merged
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Jun 14, 2019
@teosarca
Update ADProcessInstancesRepository.java
7417e5a 
throw exception if no instance created

metasfresh/metasfresh#5257
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Jun 14, 2019
@teosarca
minor
daf942b 
metasfresh/metasfresh#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
Create AdTableId.java
3edd9fe 
#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
IADTableDAO.retrieveTableName
fafcc45 
#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
IADWindowDAO.getWindowIdByInternalName
481cd0c 
#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
POInfo.getPOInfo(AdTableId)
2117793 
#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
Update DataEntryRecordCacheTest.java
937ad8f 
avoid using ITableRecordReference

#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
Update AbstractImportProcess.java
3d4824b 
when reporting error, also invalidate the cache, else webui won't show the new values

#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
prototyping
61ec62c 
#5257
@teosarca teosarca mentioned this issue Jun 14, 2019
Merged
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
Update DataEntryRecordsImportProcess.java
96724b2 
set DataEntry_Record_ID

#5257
teosarca added a commit that referenced this issue Jun 14, 2019
@teosarca
minor
5fdc641 
#5257
teosarca added a commit that referenced this issue Jun 18, 2019
@teosarca
MTable.getTableName: fixes for unit testing
6f0cf52 
#5257
teosarca added a commit that referenced this issue Jun 18, 2019
@teosarca
fixing unit test
ea66d13 
#5257
teosarca added a commit that referenced this issue Jun 18, 2019
@teosarca
improve data entry record import
0cb363b 
#5257
teosarca added a commit that referenced this issue Jun 18, 2019
@teosarca
Update DataEntryRecordsImportProcess.java
c8282fb 
improve error message

#5257
teosarca added a commit that referenced this issue Jun 18, 2019
@teosarca
Create 5525110_sys_gh5257_enable_remove_cache_invalidation.sql
465c386 
#5257
teosarca added a commit that referenced this issue Jun 18, 2019
@teosarca
fixing failing test
7eb6c5e 
#5257
teosarca added a commit that referenced this issue Jun 21, 2019
@teosarca
fix NamePattern
14b897a 
#5257
teosarca added a commit that referenced this issue Jul 3, 2019
@teosarca
Update NumberUtils.java
3c7ad11 
avoid logging the number conversion error because it's flooding the console

#5257
teosarca added a commit that referenced this issue Jul 3, 2019
@teosarca
DataEntryRecordField.convertValueToFieldType: handle list values
09e5a96 
#5257
metas-ts added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Jul 3, 2019
@metas-ts
DataEntryRecordField.convertValueToFieldType: handle list values
e42f1e7 
follow refactoring in metasfresh
metasfresh/metasfresh#5257
metas-ts added a commit that referenced this issue Jul 3, 2019
@metas-ts
fix test by updating snaptshot
7a34923 
#5257
metas-ts added a commit that referenced this issue Jul 4, 2019
@metas-ts
fix test by updating snaptshot
39309b0 
#5257
teosarca added a commit that referenced this issue Jul 4, 2019
@teosarca
Create 5526680_sys_gh5257_AD_ChangeLog_convert_Value_fields_to_TextLo…
7ea1ce8 
…ng.sql

#5257
teosarca added a commit that referenced this issue Jul 4, 2019
@teosarca
Create 5526690_sys_gh5257_DataEntryRecord_imp_format_shall_use_semico…
f758bd5 
…lumn_separator.sql

#5257
teosarca added a commit that referenced this issue Jul 5, 2019
@teosarca
Create 5526730_sys_gh5257_DataEntryRecord_import_filter.sql
5419924 
#5257
teosarca added a commit that referenced this issue Jul 5, 2019
@teosarca
hotfix DataEntryRecord: changing a value to null was causing NPE
6459ad7 
#5257
metas-ts added a commit that referenced this issue Jul 8, 2019
@metas-ts
update ReleaseNotes.md
376f9f7 
  * [#5257](#5257) Data Migration for Data Entry
  * [#5353](#5353) Enable "Bank" import
  * [#85](metasfresh/metasfresh-e2e-legacy#85) Create new Packing Instruction / Packing Instruction Version
  * [#134](metasfresh/metasfresh-e2e-legacy#134) Create credit memo price difference for sales invoice
  * [#135](metasfresh/metasfresh-e2e-legacy#135) Create credit memo deliver difference for sales invoice
  * [#152](metasfresh/metasfresh-e2e-legacy#152) Change shipment date and date ready in shipment schedule
  * [#188](metasfresh/metasfresh-e2e-legacy#188) move defunct specs into dedicated folder
  * [#189](metasfresh/metasfresh-e2e-legacy#189) Create Nachbelastung Mengendifferenz for sales invoice
  * [#190](metasfresh/metasfresh-e2e-legacy#190) Create Adjustment Charge (Nachbelastung Preisdifferenz) for sales invoice
  * [#1740](metasfresh/metasfresh-webui-frontend-legacy#1740) email Editor Adress Lookup behavior
  * [#5346](#5346) Pricing Condition fixes
  * [#2292](metasfresh/metasfresh-webui-frontend-legacy#2292) Doubleclick does not work on mobile (iOS)
  * [#2308](metasfresh/metasfresh-webui-frontend-legacy#2308) Dev cypress run hangs
teosarca added a commit that referenced this issue Jul 11, 2019
@teosarca
handle annotated ReferenceListAwareEnum parameters
5550876 
#5257
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Jul 11, 2019
@teosarca
DefaultViewsRepositoryStorage.invalidateAll: fire websocket event
939cc4c 
metasfresh/metasfresh#5257
teosarca added a commit that referenced this issue Jul 11, 2019
@teosarca
IImportProcessFactory: setDeleteImportDataProcessClass + QA/improvements
caf4392 
#5257
teosarca added a commit that referenced this issue Jul 11, 2019
@teosarca
IImportProcess.deleteImportRecords
bc98219 
#5257
teosarca added a commit that referenced this issue Jul 11, 2019
@teosarca
Create 5527090_sys_gh5257_DeleteImportDataProcess.sql
58c60d7 
#5257
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Jul 11, 2019
@teosarca
WebuiDataImportConfiguration
f30f53a 
metasfresh/metasfresh#5257
This was referenced Jul 11, 2019
Merged
Merged
teosarca added a commit that referenced this issue Jul 11, 2019
@teosarca
Create 5527110_sys_gh5257_trls.sql
5513620 
#5257
@rajeshkannan1969
Copy link

Can this be utilized for internal use transactions upload datewise

@metas-Kay metas-Kay mentioned this issue Jul 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release topic:DataEntry type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @rajeshkannan1969