#409 Aded UOM conversion check when adding a new price to a product. #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metas-ts
requested changes
Jan 9, 2020
| { | ||
| return; | ||
| } | ||
| throw new AdempiereException("UOM Conversion to the selected UOM doesn't exist").markAsUserValidationError(); |
There was a problem hiding this comment.
Create an AD_Message record with translations (we'll need en_US, de_DE and de_CH) and use IMsg (Services.get(IMsg.class)) to get a translatable string instance.
Passing hardcoded strings generally doesn't make sense for user-errors
metas-ts
requested changes
Jan 9, 2020
metas-ts
requested changes
Jan 9, 2020
de.metas.business/src/main/java/de/metas/pricing/service/ProductPrices.java
Show resolved
Hide resolved
metas-ts
approved these changes
Jan 10, 2020
|
Complexity increasing per file
==============================
- de.metas.business/src/main/java/de/metas/pricing/service/ProductPrices.java 2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6007