#409 Aded UOM conversion check when adding a new price to a product.

de.metas.adempiere.adempiere/migration/src/main/sql/postgresql/system/10-de.metas.adempiere/5540970_sys_gh409_addedErrorMessageForNoUOMConversion.sql

@@ -0,0 +1,25 @@
+-- 2020-01-09T11:59:09.418Z
+-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
+INSERT INTO AD_Message (AD_Client_ID,AD_Message_ID,AD_Org_ID,Created,CreatedBy,EntityType,IsActive,MsgText,MsgType,Updated,UpdatedBy,Value) VALUES (0,544955,0,TO_TIMESTAMP('2020-01-09 13:59:09','YYYY-MM-DD HH24:MI:SS'),100,'de.metas.pricing','Y','Für die ausgewählte Preis-Maßeinheit ist keine Umrechnung verfügbar.','E',TO_TIMESTAMP('2020-01-09 13:59:09','YYYY-MM-DD HH24:MI:SS'),100,'de.metas.pricing.service.product.MissingUOMConversion')
+;
+
+-- 2020-01-09T11:59:09.422Z
+-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
+INSERT INTO AD_Message_Trl (AD_Language,AD_Message_ID, MsgText,MsgTip, IsTranslated,AD_Client_ID,AD_Org_ID,Created,Createdby,Updated,UpdatedBy) SELECT l.AD_Language, t.AD_Message_ID, t.MsgText,t.MsgTip, 'N',t.AD_Client_ID,t.AD_Org_ID,t.Created,t.Createdby,t.Updated,t.UpdatedBy FROM AD_Language l, AD_Message t WHERE l.IsActive='Y'AND (l.IsSystemLanguage='Y' AND l.IsBaseLanguage='N') AND t.AD_Message_ID=544955 AND NOT EXISTS (SELECT 1 FROM AD_Message_Trl tt WHERE tt.AD_Language=l.AD_Language AND tt.AD_Message_ID=t.AD_Message_ID)
+;
+
+-- 2020-01-09T11:59:19.637Z
+-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
+UPDATE AD_Message_Trl SET MsgText='No conversion is available for the selected price unit.',Updated=TO_TIMESTAMP('2020-01-09 13:59:19','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Language='en_US' AND AD_Message_ID=544955
+;
+
+-- 2020-01-09T12:01:14.534Z
+-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
+UPDATE AD_Message_Trl SET IsTranslated='Y', MsgText='Für die ausgewählte Preis-Masseinheit ist keine Umrechnung verfügbar.',Updated=TO_TIMESTAMP('2020-01-09 14:01:14','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Language='de_CH' AND AD_Message_ID=544955
+;
+
+-- 2020-01-09T12:01:35.173Z
+-- I forgot to set the DICTIONARY_ID_COMMENTS System Configurator
+UPDATE AD_Message_Trl SET IsTranslated='Y',Updated=TO_TIMESTAMP('2020-01-09 14:01:35','YYYY-MM-DD HH24:MI:SS'),UpdatedBy=100 WHERE AD_Language='en_US' AND AD_Message_ID=544955
+;
+

de.metas.business/src/main/java/de/metas/pricing/interceptor/M_ProductPrice.java

@@ -36,7 +36,6 @@
  */
 
 /**
- *
  * @author metas-dev <dev@metasfresh.com>
  * @task Prevent users from creating duplicate main prices https://github.com/metasfresh/metasfresh/issues/2510
  */
@@ -57,4 +56,10 @@ public void assertMainProductPriceIsNotDuplicate(@NonNull final I_M_ProductPrice
 	{
 		ProductPrices.assertMainProductPriceIsNotDuplicate(productPrice);
 	}
+
+	@ModelChange(timings = { ModelValidator.TYPE_AFTER_NEW, ModelValidator.TYPE_AFTER_CHANGE }, ifColumnsChanged = { I_M_ProductPrice.COLUMNNAME_C_UOM_ID, I_M_ProductPrice.COLUMNNAME_IsInvalidPrice, I_M_ProductPrice.COLUMNNAME_IsActive })
+	public void assertUomConversionExists(@NonNull final I_M_ProductPrice productPrice)
+	{
+		ProductPrices.assertUomConversionExists(productPrice);
+	}
 }

de.metas.business/src/main/java/de/metas/pricing/service/ProductPrices.java

@@ -15,6 +15,10 @@
 
 import javax.annotation.Nullable;
 
+import de.metas.i18n.ITranslatableString;
+import de.metas.uom.IUOMConversionDAO;
+import de.metas.uom.UOMConversionsMap;
+import de.metas.uom.UomId;
 import org.adempiere.exceptions.AdempiereException;
 import org.adempiere.model.InterfaceWrapperHelper;
 import org.compiere.model.I_M_PriceList;
@@ -62,6 +66,8 @@
 
 public class ProductPrices
 {
+	private static final String MSG_NO_UOM_CONVERSION_AVAILABLE = "de.metas.pricing.service.product.MissingUOMConversion";
+
 	private static final CopyOnWriteArrayList<IProductPriceQueryMatcher> MATCHERS_MainProductPrice = new CopyOnWriteArrayList<>();
 
 	private static final Logger logger = LogManager.getLogger(ProductPrices.class);
@@ -76,7 +82,7 @@ public static final ProductPriceQuery newQuery(@NonNull final I_M_PriceList_Vers
 	/**
 	 * Convenient method to check if the main product price exists.
 	 *
-	 * @param plv price list version or null
+	 * @param plv       price list version or null
 	 * @param productId product (negative values are tolerated)
 	 * @return true if exists
 	 */
@@ -102,7 +108,7 @@ public static void assertMainProductPriceIsNotDuplicate(final I_M_ProductPrice p
 			return;
 		}
 
-		if(productPrice.isInvalidPrice())
+		if (productPrice.isInvalidPrice())
 		{
 			return;
 		}
@@ -124,6 +130,39 @@ public static void assertMainProductPriceIsNotDuplicate(final I_M_ProductPrice p
 		getFirstOrThrowExceptionIfMoreThanOne(allMainPrices);
 	}
 
+	public static void assertUomConversionExists(final I_M_ProductPrice productPrice)
+	{
+		if (productPrice == null || !productPrice.isActive())
+		{
+			return;
+		}
+
+		if (productPrice.isInvalidPrice())
+		{
+			return;
+		}
+
+		final IProductDAO productDAO = Services.get(IProductDAO.class);
+		final org.compiere.model.I_M_Product product = productDAO.getById(productPrice.getM_Product_ID());
+
+		if (UomId.ofRepoId(product.getC_UOM_ID()).equals(UomId.ofRepoId(productPrice.getC_UOM_ID())))
+		{
+			return;
+		}
+
+		final IUOMConversionDAO uomConversionRepo = Services.get(IUOMConversionDAO.class);
+		final ProductId productId = ProductId.ofRepoId(productPrice.getM_Product_ID());
+
+		UOMConversionsMap conversionsMap = uomConversionRepo.getProductConversions(productId);
+
+		if (!conversionsMap.getRateIfExists(UomId.ofRepoId(product.getC_UOM_ID()), UomId.ofRepoId(productPrice.getC_UOM_ID())).isPresent())
+		{
+			final IMsgBL msgBL = Services.get(IMsgBL.class);
+			final ITranslatableString message = msgBL.getTranslatableMsgText(MSG_NO_UOM_CONVERSION_AVAILABLE);
+			throw new AdempiereException(message).markAsUserValidationError();
+		}
+	}
+
 	public static final I_M_ProductPrice retrieveMainProductPriceOrNull(final I_M_PriceList_Version plv, final ProductId productId)
 	{
 		final List<I_M_ProductPrice> allMainPrices = retrieveAllMainPrices(plv, productId);
@@ -255,7 +294,6 @@ public static <T extends I_M_ProductPrice> T iterateAllPriceListVersionsAndFindP
 				return productPrice;
 			}
 
-
 			currentPriceListVersion = priceListsRepo.getBasePriceListVersionForPricingCalculationOrNull(currentPriceListVersion, priceDate);
 		}