only set C_OLCand.ProductDescription if different from product-name #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise there is no point, and e.g. invoice jaspers vill look as if the product name is printed twice on them
fix both a unit test and the actual code
|
Complexity decreasing per file
==============================
+ de.metas.salescandidate.base/src/main/java/de/metas/ordercandidate/modelvalidator/C_OLCand.java -1
See the complete overview on Codacy |
metas-ts
added a commit
that referenced
this pull request
Jan 17, 2020
…6054) * only set C_OLCand.ProductDescription if different from product-name otherwise there is no point, and e.g. invoice jaspers vill look as if the product name is printed twice on them * only set C_OLCand.ProductDescription if different from product-name fix both a unit test and the actual code (cherry picked from commit b6d4c5d)
metas-ts
added a commit
that referenced
this pull request
Jan 27, 2020
metas-ts
added a commit
that referenced
this pull request
Feb 3, 2020
* [#6054](#6054) only set C_OLCand.ProductDescription if different from product-name * [#6077](#6077) Add grouping warehouse in Bestellkontrolle report * [#6085](#6085) Presetting of Qty CU and default LU in action receipt * [#6098](#6098) bump up lombok version to 1.18.10 * [#8](metasfresh/metasfresh-edi-legacy#8) EDI - add switch to disable delivery variance element * [#5](metasfresh/metasfresh-parent-legacy#5) Generate git.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise there is no point, and e.g. invoice jaspers vill look as if the product name is printed twice on them