Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh 265 #8

Merged
merged 3 commits into from
May 4, 2016
Merged

Fresh 265 #8

merged 3 commits into from
May 4, 2016

Conversation

metas-rc
Copy link
Member

@metas-rc metas-rc commented May 4, 2016

Please, review and merge

@teosarca teosarca self-assigned this May 4, 2016
return model.getM_HU_PI_Item_Product_ID();
final I_M_HU_PI_Item_Product huPIP = Services.get(IPMMPurchaseCandidateBL.class).getM_HU_PI_Item_Product_Effective(model);

return huPIP == null ? -1 : huPIP.getM_HU_PI_Item_Product_ID();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls introduce and use IPMMPurchaseCandidateBL.getM_HU_PI_Item_Product_Effective_ID(model) to avoid unnecessary database loads

Fixes after review
@teosarca teosarca merged commit 26400fe into master May 4, 2016
@teosarca teosarca deleted the FRESH-265 branch May 4, 2016 15:26
teosarca added a commit that referenced this pull request Sep 7, 2016
* made it faster
*  improved/fixed Language.getLanguage(Locale)
* use Query API
metas-ts added a commit that referenced this pull request Feb 3, 2020
  * [#6054](#6054) only set C_OLCand.ProductDescription if different from product-name
  * [#6077](#6077) Add grouping warehouse in Bestellkontrolle report
  * [#6085](#6085) Presetting of Qty CU and default LU in action receipt
  * [#6098](#6098) bump up lombok version to 1.18.10
  * [#8](metasfresh/metasfresh-edi-legacy#8) EDI - add switch to disable delivery variance element
  * [#5](metasfresh/metasfresh-parent-legacy#5) Generate git.properties
metas-ts added a commit that referenced this pull request Apr 11, 2020
metas-ts added a commit that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants