Gh7012 receipt schedule adj #7047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO * unit tests for ShipmentCandidateExporter and ShipmentScheduleAuditRepository * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinante what's missing #7012
TODO * unit tests for ShipmentCandidateExporter and ShipmentScheduleAuditRepository * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinante what's missing #7012
TODO * unit tests for ShipmentCandidateExporter * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
…' into gh7012_shipmentschedule_rest_api
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
(cherry picked from commit fd95e03)
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
added issues
TODO * MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules * dev-test; * also see & coordinate what's missing #7012
# Conflicts: # backend/de.metas.swat/de.metas.swat.base/src/main/java-gen/de/metas/inoutcandidate/model/X_M_Packageable_V.java
* Use jackson-stuff in our camel route * Send feedback to metasfresh * Update audit records using feedback * convert JSON to XML * simplify audit records in metasfresh * Also * CacheInvalidateMultiRequest with better support for RepoIdAwares #7012
This reverts commit e2e8a81
- can no longer reactivate or void purchase order with exported receipt schedules. - new process to change the export status of receipt schedules.
dragospodariu96
changed the base branch from
master
to
gh7012_shipmentschedule_rest_api
metas-ts
requested changes
Jul 22, 2020
Comment on lines
136
to
138
| // | ||
| // Cache invalidate | ||
| // We have to do this even if invalidate=false |
| * @author dp | ||
| */ | ||
|
|
||
| public interface IReceiptSchedulePA extends ISingletonService |
There was a problem hiding this comment.
(as written in the concept review, please go with the existing IReceiptScheduleDAO instead)
| { | ||
| // relatively small amount of records | ||
| // => fetch and reset individually | ||
| final ImmutableSet<ReceiptScheduleId> shipmentScheduleIds = queryBL.createQueryBuilder(I_M_ReceiptSchedule.class) |
There was a problem hiding this comment.
Suggested change
| final ImmutableSet<ReceiptScheduleId> shipmentScheduleIds = queryBL.createQueryBuilder(I_M_ReceiptSchedule.class) | |
| final ImmutableSet<ReceiptScheduleId> receiptScheduleIds = queryBL.createQueryBuilder(I_M_ReceiptSchedule.class) |
Base automatically changed from
gh7012_shipmentschedule_rest_api
to
blonde_monkey_uat
July 23, 2020 06:01
Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com> Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com> Co-authored-by: TheBestPessimist <cristian@tbp.land> Co-authored-by: Kay <kay.kostelnik@metasfresh.com> Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com> Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com> Co-authored-by: Peter Wyss <peter.wyss@kommunikativ.ch> Co-authored-by: Kuba Siemiątkowski <kuba@saskla.cz> Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com>
# Conflicts: # backend/de.metas.swat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/exportaudit/APIExportStatus.java # backend/de.metas.swat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/modelvalidator/C_Order.java
metas-ts
approved these changes
Jul 23, 2020
# Conflicts: # backend/de.metas.swat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/modelvalidator/C_Order.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7012