Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrDataset will not use the projection interface #1071

Closed
kaypark-skt opened this issue Dec 11, 2018 · 1 comment
Closed

PrDataset will not use the projection interface #1071

kaypark-skt opened this issue Dec 11, 2018 · 1 comment
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
@dataprep Component Name : Data preparation refactoring should not contain any new feature
Milestone
3.2.0

Comments

@kaypark-skt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We decided not to use projection in the dataset because of management issues.

Describe the solution you'd like
The projection interface of PrDataset will be removed
"detail" projection won't use.
"preview" parameter will be used instead.

Describe alternatives you've considered

Additional context
@kaypark-skt kaypark-skt added the @dataprep Component Name : Data preparation label Dec 11, 2018
@kaypark-skt kaypark-skt added this to the 3.2.0 milestone Dec 11, 2018
kaypark-skt pushed a commit that referenced this issue Dec 11, 2018
@kaypark-sk
#1071 dataset has no projection
fd3ac1b
@kaypark-skt kaypark-skt assigned paigechoi and unassigned kaypark-skt Dec 11, 2018
@kaypark-skt
Copy link
Contributor Author

dataset doesn't use projection interface.
@paigechoi is an assignee now.

kaypark-skt pushed a commit that referenced this issue Dec 12, 2018
@kaypark-sk
#1071 add creatorDfName to w.dataset
c1a53ed
kaypark-skt pushed a commit that referenced this issue Dec 17, 2018
@kaypark-sk
#1071 entity has associative entity as child node rather than _embedd…
10b332b 
…ed field
kaypark-skt pushed a commit that referenced this issue Dec 18, 2018
@kaypark-sk
#1071 remove JsonManagedReference annotation because of deserialization
3db8c62
paigechoi added a commit that referenced this issue Dec 18, 2018
@paigechoi
#1071 Fix UI code - PrDataset removed projection interface
92f1264
@paigechoi paigechoi mentioned this issue Dec 19, 2018
Merged
9 tasks
paigechoi added a commit that referenced this issue Dec 19, 2018
@paigechoi
F#1071 dataset has no projection (#1113)
4163190 
* #1071 dataset has no projection

* #1071 add creatorDfName to w.dataset

* #1071 entity has associative entity as child node rather than _embedded field

* #1071 remove JsonManagedReference annotation because of deserialization

* #1071 Fix UI code - PrDataset removed projection interface

* 1071 Fix dataset information in dataset detail and dataflow panel
paigechoi added a commit that referenced this issue Dec 19, 2018
@paigechoi
#1071 Fix add dataset to existing dataflow error
fb1edbb
@paigechoi paigechoi mentioned this issue Dec 19, 2018
Merged
9 tasks
paigechoi added a commit that referenced this issue Dec 19, 2018
@paigechoi
#1071 Fix overlapping css in add to dataflow popup(in dataset detail)
e105ad0
@joohokim1 joohokim1 reopened this Dec 20, 2018
paigechoi added a commit that referenced this issue Dec 20, 2018
@paigechoi
#1071 Fix add dataset to existing dataflow error (#1137)
5ef720c 
* #1071 Fix add dataset to existing dataflow error

* #1071 Fix overlapping css in add to dataflow popup(in dataset detail)
@joohokim1 joohokim1 added the refactoring should not contain any new feature label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation refactoring should not contain any new feature
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt