New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending request too many times when getting snapshot list #1220

Closed
paigechoi opened this Issue Jan 9, 2019 · 0 comments

Comments

Projects
None yet
3 participants
@paigechoi
Copy link
Contributor

paigechoi commented Jan 9, 2019

Describe the bug
In order to get the information about snapshot creation process,
API is requested every second (aka polling).

To Reproduce
Go to dataflow main grid -> create a snapshot -> check network

Expected behavior
API should be requested when one request is finished.

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Combining rule list component and snapshot list component into one component.
This is because communication between two components are extremely frequent and dividing thses two component makes it harder to exchange data.

@paigechoi paigechoi added the @dataprep label Jan 9, 2019

@paigechoi paigechoi changed the title Calling API too many times when getting snapshot list Sending request too many times when getting snapshot list Jan 9, 2019

paigechoi added a commit that referenced this issue Jan 9, 2019

#1220 Modified to send a new request only when the old request is com…
…pleted. Refactoring rule list and snapshot list components

@paigechoi paigechoi added the bug label Jan 10, 2019

paigechoi added a commit that referenced this issue Jan 11, 2019

@paigechoi paigechoi referenced this issue Jan 11, 2019

Merged

F#1220 polling error in snapshot list #1239

1 of 9 tasks complete

joohokim1 added a commit that referenced this issue Jan 14, 2019

F#1220 polling error in snapshot list (#1239)
* #1220 Modified to send a new request only when the old request is completed. Refactoring rule list and snapshot list components

* #1220 fix interval clearing logic

@joohokim1 joohokim1 closed this Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment