Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply timestamp format to rename pop-up #1393

Closed
joohokim1 opened this issue Feb 8, 2019 · 2 comments
Closed

Apply timestamp format to rename pop-up #1393

joohokim1 opened this issue Feb 8, 2019 · 2 comments
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone
3.2.0

Comments

@joohokim1
Copy link
Contributor

Describe the bug
The timestamp format is not applied to rename pop-up.

To Reproduce
Steps to reproduce the behavior:

  1. Import & wrangle sales_2011_01.txt
  2. Edit rules
  3. Select setformat command.
  4. Change column1's timestamp format to 'yyyy-MMM-dd'
  5. Select rename command.
  6. Click rename all button.
  7. Timestamp format of column1 is still ISO8601 full.

Expected behavior
The user choiced timestamp format should be applied to pop-ups too.

Screenshots
2019-02-08 9 29 30

2019-02-08 9 22 50

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 68.0.3440.106
@joohokim1 joohokim1 added bug Something isn't working @dataprep Component Name : Data preparation labels Feb 8, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Feb 8, 2019
@joohokim1
Copy link
Contributor Author

It's still converting white spaces into underscores: 배송기간 (일) has changed into 배송기간_일_

2019-02-08 9 35 26

2019-02-08 9 35 45

@sang-hee-lee Please take a look at this opportunity.

@joohokim1
Copy link
Contributor Author

joohokim1 commented Feb 11, 2019 •
edited
Loading

@sang-hee-lee

Regarding on "Spaces into underscores" issue, the corresponding server API has to be changed.
It's makeParsible() in DfRename.java. I'm on it.

@paigechoi paigechoi self-assigned this Feb 11, 2019
paigechoi added a commit that referenced this issue Feb 13, 2019
@paigechoi
#1393 Add timestamp format to rename popup data
429c5ba
@paigechoi paigechoi mentioned this issue Feb 14, 2019
Merged
9 tasks
kaypark-skt pushed a commit that referenced this issue Feb 15, 2019
@paigechoi @kaypark-skt
#1393 Add timestamp format to rename popup data (#1432)
f6e9ef4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@paigechoi @sang-hee-lee @joohokim1 @kaypark-skt