Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1393 Add timestamp format to rename popup data #1432

Merged
merged 1 commit into from
Feb 15, 2019
Merged

#1393 Add timestamp format to rename popup data #1432

merged 1 commit into from
Feb 15, 2019

Conversation

paigechoi
Copy link
Contributor

@paigechoi paigechoi commented Feb 14, 2019 •
edited
Loading

Description

Apply timestamp format to rename popup

Related Issue :

#1393

How Has This Been Tested?

Go to dataprep main grid -> change one column type to timestamp
-> open multi column rename popup (rename command) -> see if timestamp format is applied in grid data

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@paigechoi paigechoi self-assigned this Feb 14, 2019
@joohokim1 joohokim1 added the @dataprep Component Name : Data preparation label Feb 14, 2019
@kaypark-skt kaypark-skt added the testbed5 Review Test Server 5 label Feb 14, 2019
@kaypark-skt kaypark-skt added this to the 3.2.0 milestone Feb 14, 2019
@kaypark-skt
Copy link
Contributor

run build
deploy to 5

@kaypark-skt kaypark-skt merged commit f6e9ef4 into master Feb 15, 2019
@alchan-lee alchan-lee deleted the f#1393-rename_popup_timestamp_format branch February 21, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sang-hee-lee sang-hee-lee sang-hee-lee approved these changes

@kaypark-skt kaypark-skt kaypark-skt approved these changes

@nowone123 nowone123 Awaiting requested review from nowone123

@joohokim1 joohokim1 Awaiting requested review from joohokim1

Assignees

@paigechoi paigechoi

Labels
@dataprep Component Name : Data preparation testbed5 Review Test Server 5
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paigechoi @kaypark-skt @sang-hee-lee @joohokim1