Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter; if two table has same column names, it cannot apply to both table #1901

Closed
wm9947 opened this issue Apr 19, 2019 · 4 comments
Closed
Assignees
Labels
bug Something isn't working @dashboard Component Name : Dashboard / Chart p1 Priority 1
Milestone

Comments

@wm9947
Copy link

wm9947 commented Apr 19, 2019

When table1 and table2 contain same column name, the filter function can use for only one table.

ex) I made a filter for table1 column price.
But table2 also contain column which is price.
So I want to make a filter for table2 price column.
-> It does not work.

if tables contain same name of the column, not only it cannot apply both, but also it cannot make separately.

Could you check it?

Many thanks,

@kyungtaak
Copy link
Contributor

@wm9947 you mean this situation?
multi_column_samename

@wm9947
Copy link
Author

wm9947 commented Apr 23, 2019

@kyungtaak
yes. The table name is not changed. and this filter is not apply to both tables.

@kyungtaak kyungtaak added this to the 3.3.0 milestone Apr 23, 2019
@kyungtaak kyungtaak added @dashboard Component Name : Dashboard / Chart bug Something isn't working labels Apr 23, 2019
@kyungtaak
Copy link
Contributor

@wm9947 ok! We'll fix this soon.

@eltriny Can you confirm and fix this bug?

@kyungtaak kyungtaak added the p1 Priority 1 label Apr 24, 2019
kyungtaak pushed a commit that referenced this issue May 2, 2019
…both table

* #1901 Change the filter checking method in use

* #1901 Open panel when add new filter, fix error resize dashboard when empty
eltriny added a commit that referenced this issue May 2, 2019
…both table

* #1901 Change the filter checking method in use

* #1901 Open panel when add new filter, fix error resize dashboard when empty
@kyungtaak
Copy link
Contributor

@wm9947 This error has been fixed and merged into the master. Please check it out for tomorrow's release and let me know if there's a problem.
And I'll this issue. Thank you for your bug report! :)

alchan-lee pushed a commit that referenced this issue May 2, 2019
…estion stage (#1988)

* #1940 change column name in datasource create step

- add sliced name method in Field.ts

* #1940 add content slice logic in datasource create step

* #1912 do not check upstream's column name for hive snapshot

* #1811 update readme file


- Change images and add contents to "Screenshots" .
- Edit link to discussion forum in Question section.
- Editing Intuitive UI in "strengths" to single solution.
- Add "geo data analysis" to key features
- Edit "Question" section to link our google groups.
- Change "dashboard" image in Readme.md
- Delete Metatron in Chinese from screenshot section.
- Add multiple language support to key features

* #1956 Searching database does not work on the Hive Connection Workbench. (#1958)

* #1960 fix errors that can not be entered into a workbook or workbench in I.E

* #1816 improve upload local file on ingestion stage


- Add progress bar

* Update PULL_REQUEST_TEMPLATE.md

* #1911 change default quote in druid jdbc

* #1922 fix access denied when clientId is different

* #fn Add unit tests for app.metatron.discovery.prep.parser.preparation.rule.expr.Pair

Add unit tests for prep parser

* #1970 fix error affecting database changes in the schema browser

* #1975 fix dashboard critical issues on IE11 - image down / field list / save empty dashboard

* #1974 fix css error in IE11

* #1068 Fix css - datasource file upload (IE)

* #1062 Fix create shared workspace combo box align in IE

* #1062 Fix css in workspace datasource list

* #1062 Add preset schema combo box min width

* #1062 Fix metatron login page css (IE)

* #1062 Fix grid css where header and row line did not match

* #1968 Fix css in chart layout slider

* #1968 fix css and logic where the logical column area is selected only half of the line

* #1968 Fix hover css in permission schema popup

* #1968 Fixed an issue where the disabled icon was not displayed when mouse over the disabled column

* #1968 fix css in chart hierarchy

* #1971 to read csv without BOM (#1973)

* #1933 Internationalize mailing template

* Fix Mail Template

* Fix template when added by admin

* #1882 rediction line (#1935)

* #1882 Fixed an error in which the predicted line was not drawn

* #1882 Improved input and fix error undefined field name

* #1901 filter; if two table has same column names, it cannot apply to both table

* #1901 Change the filter checking method in use

* #1901 Open panel when add new filter, fix error resize dashboard when empty

* #1954 remove confirm when creating datasource via workbench

* #1983 fix extension dbtype workbench 

* fn fix extension db type in workbench

* fn change type all label in workbench create

* fn fix parameter type

* #1982 fix checkbox in notebook list

* fn fix checkbox in notebook list

* fn fix checkbox select when notebook list empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @dashboard Component Name : Dashboard / Chart p1 Priority 1
Projects
None yet
Development

No branches or pull requests

3 participants