Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar for local file upload on ingestion stage #1816

Closed
kyungtaak opened this issue Apr 7, 2019 · 5 comments
Closed

Add progress bar for local file upload on ingestion stage #1816

kyungtaak opened this issue Apr 7, 2019 · 5 comments
Assignees
@kyungtaak @eltriny @brandon-wonjune @joohokim1
Labels
@datasource Component Name : Datasource/Connection Management enhancement Request Change and Feature Enhancement p1 Priority 1
Milestone
3.3.0

Comments

@kyungtaak
Copy link
Contributor

kyungtaak commented Apr 7, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

  • Improve the upload UI so users know intuitively about file upload status.

Describe the solution you'd like

  • Displays the progress bar so that users can check the progress when uploading a file.
@kyungtaak kyungtaak added enhancement Request Change and Feature Enhancement @datasource Component Name : Datasource/Connection Management labels Apr 7, 2019
@kyungtaak kyungtaak added this to the 3.3.0 milestone Apr 7, 2019
@brandon-wonjune brandon-wonjune self-assigned this Apr 16, 2019
brandon-wonjune added a commit that referenced this issue Apr 16, 2019
@brandon-wonjune
#1816 create pluploader setting
78ee9b2
@kyungtaak kyungtaak added the p1 Priority 1 label Apr 19, 2019
@kyungtaak kyungtaak changed the title Improve handling large file on ingestion stage Improve handling local file on ingestion stage Apr 19, 2019
@brandon-wonjune
Copy link
Contributor

brandon-wonjune commented Apr 22, 2019 •
edited
Loading

@metatron-app/design 이 화면은 어떤 변경된 UI를 적용하면되나요?

@brandon-wonjune brandon-wonjune added the awaiting feedback need to feedback label Apr 22, 2019
@deidera08
Copy link

@brandon-wonjune 화면 기획중입니다. 완료되는대로 공유드리도록 하겠습니다.

brandon-wonjune added a commit that referenced this issue Apr 23, 2019
@brandon-wonjune
#1816 fix pluploader option builder file
6cf87a3
@deidera08
Copy link

@kyungtaak @AnnieHwang @brandon-wonjune
화면 기획안 공유드립니다. 파일 업로드시 진행바가 추가되었습니다.
#1816_Improve handling local file.pptx

@koeun222
Copy link

koeun222 commented Apr 23, 2019 •
edited
Loading

@AnnieHwang @deidera08 디자인화면 공유드립니다- 각 상태별 알림문구(노랑) 확인부탁드려요~

1.초기상태
image

  1. 파일업로드 중
    image

3.파일 업로드 중 취소
image

@deidera08
Copy link

@kyungtaak @AnnieHwang @brandon-wonjune
 파일을 1차적으로 업로드 완료 이후에 유저가 다른 파일로 올릴 경우 상황에 정리가 안되어 다음과 같이 보완합니다.

기본적으로 파일을 업로드 성공하면 Preview화면으로 자동 진입합니다.
스크린샷 2019-04-24 오후 5 25 42

본 화면에서 제공하던 '다른 파일로 업로드'기능은 삭제합니다.
다만 이전단계로 가는 버튼을 둬서 사용자가 이전화면에서 다른 파일로 올릴 수 있습니다.
스크린샷 2019-04-24 오후 5 25 54

이전화면으로 진입한다고 해도 사용자가 다른 파일을 올리기 전까지 기존에 올려둔 파일의 정보는 유지해야 합니다.

brandon-wonjune added a commit that referenced this issue Apr 25, 2019
@brandon-wonjune
#1816 add uploader css and message property
f3486da
brandon-wonjune added a commit that referenced this issue Apr 25, 2019
@brandon-wonjune
#1816 fix pluploader builder file
64636a1
brandon-wonjune added a commit that referenced this issue Apr 25, 2019
@brandon-wonjune
#1816 add file uploader step in datasource create
d34e337
brandon-wonjune added a commit that referenced this issue Apr 25, 2019
@brandon-wonjune
#1816 add upload error handler
c8bddc9
brandon-wonjune added a commit that referenced this issue Apr 25, 2019
@brandon-wonjune
#1816 change pluploader file namespace
00da731
@brandon-wonjune brandon-wonjune mentioned this issue Apr 25, 2019
Merged
9 tasks
brandon-wonjune added a commit that referenced this issue Apr 26, 2019
@brandon-wonjune
#1816 add disabled next button class
6511c52
@kyungtaak kyungtaak changed the title Improve handling local file on ingestion stage Improve upload local file on ingestion stage Apr 28, 2019
@kyungtaak kyungtaak mentioned this issue Apr 28, 2019
Closed
kyungtaak pushed a commit that referenced this issue Apr 28, 2019
@brandon-wonjune @kyungtaak
#1816 improve upload local file on ingestion stage
ea75294 
- Add progress bar
@kyungtaak kyungtaak removed the awaiting feedback need to feedback label Apr 28, 2019
@kyungtaak kyungtaak changed the title Improve upload local file on ingestion stage Add progress bar for local file upload on ingestion stage Apr 28, 2019
eltriny pushed a commit that referenced this issue May 2, 2019
@brandon-wonjune
#1816 improve upload local file on ingestion stage
8c7d926 
- Add progress bar
alchan-lee pushed a commit that referenced this issue May 2, 2019
@eltriny @alchan-lee
#1940 Improved UI performance when column content size is long on ing…
6555dbd 
…estion stage (#1988)

* #1940 change column name in datasource create step

- add sliced name method in Field.ts

* #1940 add content slice logic in datasource create step

* #1912 do not check upstream's column name for hive snapshot

* #1811 update readme file


- Change images and add contents to "Screenshots" .
- Edit link to discussion forum in Question section.
- Editing Intuitive UI in "strengths" to single solution.
- Add "geo data analysis" to key features
- Edit "Question" section to link our google groups.
- Change "dashboard" image in Readme.md
- Delete Metatron in Chinese from screenshot section.
- Add multiple language support to key features

* #1956 Searching database does not work on the Hive Connection Workbench. (#1958)

* #1960 fix errors that can not be entered into a workbook or workbench in I.E

* #1816 improve upload local file on ingestion stage


- Add progress bar

* Update PULL_REQUEST_TEMPLATE.md

* #1911 change default quote in druid jdbc

* #1922 fix access denied when clientId is different

* #fn Add unit tests for app.metatron.discovery.prep.parser.preparation.rule.expr.Pair

Add unit tests for prep parser

* #1970 fix error affecting database changes in the schema browser

* #1975 fix dashboard critical issues on IE11 - image down / field list / save empty dashboard

* #1974 fix css error in IE11

* #1068 Fix css - datasource file upload (IE)

* #1062 Fix create shared workspace combo box align in IE

* #1062 Fix css in workspace datasource list

* #1062 Add preset schema combo box min width

* #1062 Fix metatron login page css (IE)

* #1062 Fix grid css where header and row line did not match

* #1968 Fix css in chart layout slider

* #1968 fix css and logic where the logical column area is selected only half of the line

* #1968 Fix hover css in permission schema popup

* #1968 Fixed an issue where the disabled icon was not displayed when mouse over the disabled column

* #1968 fix css in chart hierarchy

* #1971 to read csv without BOM (#1973)

* #1933 Internationalize mailing template

* Fix Mail Template

* Fix template when added by admin

* #1882 rediction line (#1935)

* #1882 Fixed an error in which the predicted line was not drawn

* #1882 Improved input and fix error undefined field name

* #1901 filter; if two table has same column names, it cannot apply to both table

* #1901 Change the filter checking method in use

* #1901 Open panel when add new filter, fix error resize dashboard when empty

* #1954 remove confirm when creating datasource via workbench

* #1983 fix extension dbtype workbench 

* fn fix extension db type in workbench

* fn change type all label in workbench create

* fn fix parameter type

* #1982 fix checkbox in notebook list

* fn fix checkbox in notebook list

* fn fix checkbox select when notebook list empty
brandon-wonjune added a commit that referenced this issue May 7, 2019
@brandon-wonjune
#1816 add disable file upload in file uploading status
761fe83
@brandon-wonjune brandon-wonjune mentioned this issue May 7, 2019
Merged
7 tasks
kyungtaak pushed a commit that referenced this issue May 8, 2019
@brandon-wonjune @kyungtaak
#1816 disable file upload while uploading file
1fd9bda
eltriny pushed a commit that referenced this issue May 13, 2019
@brandon-wonjune
#1816 disable file upload while uploading file
0457191
alchan-lee pushed a commit that referenced this issue May 17, 2019
@eltriny @alchan-lee
#1921 The number of data sources in the workspace UIs are different (#…
f19110a 
…2014)

* #1921 add status property to api for datasource in workspace

* #1921 Change data source list screen design in workspace

* #1921 remove duplicate style

* #1921 Show proper error msg when similarity API fails

* #1921 add disable icon from datasource list in workspace

* #1869 remove 'typeString' property in ingestion spec.

* #2012 fix no access workbook in a workspace which is allowed anyone to access

* Set new version to 3.2.2

* #1966 fix sort error if the column of dimension role is defined as an integer

* #1816 disable file upload while uploading file

* #2009 fix dataflow icon error in ie11 

* #2009 Change svg icon to png -> IE doesn't support svg

* #2009 Add mssql svg icon for dataprep

* #1850 fix the user must not move the workbook to a workspace with watcher privileges

* #1996 fix unnatural translations on lnb

* #1921 Change data source list screen design in workspace

* #1921 remove status parameter

* #1921 Add tooltips for inactive icons and add search initialization events

* #1921 Added an disable icon to the datasource that ingestion failed

* #1921 change icon tooltip message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyungtaak kyungtaak

@eltriny eltriny

@brandon-wonjune brandon-wonjune

@joohokim1 joohokim1

Labels
@datasource Component Name : Datasource/Connection Management enhancement Request Change and Feature Enhancement p1 Priority 1
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
6 participants
@kyungtaak @eltriny @brandon-wonjune @koeun222 @joohokim1 @deidera08