Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clean menu in context menu #747

Closed
paigechoi opened this issue Nov 12, 2018 · 2 comments
Closed

Add clean menu in context menu #747

paigechoi opened this issue Nov 12, 2018 · 2 comments
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.1.0

Comments

@paigechoi
Copy link
Contributor

paigechoi commented Nov 12, 2018 •
edited

Is your feature request related to a problem? Please describe.
Add clean option in context menu. Clean has two sub buttons missing and mismatch.

Describe the solution you'd like
Event when gauge bar isn't clicked, allow user to easily add rule about mismatched or missing value.
image

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.
@paigechoi paigechoi added enhancement Request Change and Feature Enhancement @dataprep Component Name : Data preparation labels Nov 12, 2018
@paigechoi paigechoi added this to the 3.1.0 milestone Nov 12, 2018
@ecoloy
Copy link

ecoloy commented Nov 19, 2018

@paigechoi
UI storyboard changed as below. Please check.
2018-11-19 11 21 18

paigechoi added a commit that referenced this issue Nov 19, 2018
@paigechoi
#747 add clean - mismatch, missing (delete rows only)
232e974
@ecoloy
Copy link

ecoloy commented Nov 21, 2018

@paigechoi
On the new storyboard above, action for 'replace/fill with custom value' menu is not a replace rule but a set rule. Sorry.

paigechoi added a commit that referenced this issue Nov 21, 2018
@paigechoi
#747 add clean - replace/fill with custom value
7ccd540
@paigechoi paigechoi mentioned this issue Nov 21, 2018
Merged
9 tasks
paigechoi added a commit that referenced this issue Nov 23, 2018
@paigechoi
#747 - Replace with custom value - add column type in condition
4c310ef
paigechoi added a commit that referenced this issue Nov 23, 2018
@paigechoi
F#747 new context menu option (#824)
b87af05 
* #747 add clean - mismatch, missing (delete rows only)

* #747 add clean - replace/fill with custom value

* #747 - Replace with custom value - add column type in condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
4 participants
@ecoloy @paigechoi @sang-hee-lee @joohokim1