F#747 new context menu option #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/metatron-app/metatron-discovery into f#747-new_context_menu_option # Conflicts: # discovery-frontend/src/app/data-preparation/dataflow/dataflow-detail/component/edit-dataflow-rule/edit-rule/edit-rule-aggregate.component.ts # discovery-frontend/src/app/data-preparation/dataflow/dataflow-detail/component/edit-dataflow-rule/edit-rule/edit-rule-replace.component.ts
paigechoi
requested review from
sang-hee-lee,
joohokim1,
kaypark-skt and
a team
|
run build |
joohokim1
requested changes
Nov 22, 2018
|
@joohokim1 @mh0203 UI에서 ruleString 을 잘못 보내고 있는 건지 확인 부탁드립니다. |
|
@paigechoi The rule string seems to be all right. @mh0203 is now working on the bug. @paigechoi UI에서 ruleString은 제대로 전달되고 있습니다. @mh0203 님께서 지금 버그를 고치고 있는 중입니다. |
|
run build |
sang-hee-lee
previously approved these changes
Nov 23, 2018
|
This is result of [Clean - Mismatched - Replace with custom] |
joohokim1
previously approved these changes
Nov 23, 2018
…nto f#747-new_context_menu_option
paigechoi
dismissed stale reviews from joohokim1 and sang-hee-lee
via
6c443bb
|
run build |
1 similar comment
|
run build |
kaypark-skt
approved these changes
Nov 23, 2018
joohokim1
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mismatch and missing (clean) in context menu
Related Issue :
#747
How Has This Been Tested?
Types of changes
Checklist:
Additional Context