Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F#1186 edit snapshot name #1218

Merged
merged 2 commits into from
Jan 9, 2019
Merged

F#1186 edit snapshot name #1218

merged 2 commits into from
Jan 9, 2019

Conversation

paigechoi
Copy link
Contributor

@paigechoi paigechoi commented Jan 9, 2019 •
edited
Loading

Description

Allow modification of snapshot name in snapshot detail popup

Related Issue :

#1186

How Has This Been Tested?

Snapshot tab -> Change snapshot name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@paigechoi paigechoi self-assigned this Jan 9, 2019
@joohokim1 joohokim1 added @dataprep Component Name : Data preparation testbed1 Review Test Server 1 labels Jan 9, 2019
@joohokim1
Copy link
Contributor

run build
deploy to 1

joohokim1
joohokim1 approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@joohokim1 joohokim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@joohokim1 joohokim1 merged commit 0babaff into master Jan 9, 2019
@alchan-lee alchan-lee deleted the f#1186-edit_snapshot_name branch January 18, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sang-hee-lee sang-hee-lee sang-hee-lee approved these changes

@joohokim1 joohokim1 joohokim1 approved these changes

@nowone123 nowone123 Awaiting requested review from nowone123

@kaypark-skt kaypark-skt Awaiting requested review from kaypark-skt

Assignees

@paigechoi paigechoi

Labels
@dataprep Component Name : Data preparation testbed1 Review Test Server 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paigechoi @joohokim1 @sang-hee-lee