Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format placeholder in column dictionary detail #2308

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@brandon-wonjune
Copy link
Contributor

commented Jul 3, 2019

Description

컬럼 딕셔너리가 TIMESTAMP 타입이고 format이 없거나 비어있는경우 아래와 같은 placeholder가 보이도록 수정
스크린샷 2019-07-03 오전 9 31 22

Related Issue :

통합테스트

How Has This Been Tested?

  1. 메타데이터 > 컬럼 딕셔너리 > 컬럼 딕셔너리 생성
  2. 타입을 TIMESTAMP로 지정하고 format을 입력하지 않고 생성
  3. 2에서 생성한 컬럼 딕셔너리 상세화면으로 이동
  4. format부분이 placeholder가 표기되는지 확인

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@brandon-wonjune brandon-wonjune requested review from eltriny, ufoscw and AnnieHwang Jul 3, 2019

@ufoscw ufoscw added the to master label Jul 3, 2019

@ufoscw ufoscw requested a review from minhyun2 Jul 3, 2019

@ufoscw ufoscw added the testbed4 label Jul 3, 2019

@ufoscw

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

run build
deploy to 4

@ufoscw

ufoscw approved these changes Jul 3, 2019

@ufoscw ufoscw merged commit 54d3256 into 3.2.x Jul 3, 2019

1 check passed

Metatron CI
Details
@AnnieHwang

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@brandon-wonjune 컬럼딕셔너리 상세에는 No format 레이블이 안생기던데.. 맞나요?
image

@ufoscw

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@AnnieHwang TestBed4에 다른 브랜치가 테스트중이라서 안 보이는걸거에요.
지금 테스트베드 대기 PR이 많아서 머지되면 바로 다음 PR이 테스트중이라서요..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.