-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minification issue with flow-router #11756
Comments
I think it's a bug in terser's |
Published minifier-js@2.7.2. |
I'm having trouble getting this updated version to be used by Meteor. My |
@brianlukoff I published the Could you check if this solves the problem? |
Thanks! I'm not able to update to 2.7.2 though -- getting the following when I try to put
|
@brianlukoff maybe you still have the local copy? Or are you running from a checkout without pulling devel? |
Oops -- you are right -- forgot to remove my local copy. Using |
We need to find another fix for this problem. As I had to revert this fix in 2.7.3. |
@brianlukoff There is recommended flow-router fork created by @dr-dimitru https://github.com/VeliovGroup/flow-router
It is more up-to-date with regular release cycle. Could you check it? |
Yes, this is what I suggested here as well. |
@afrokick Thanks -- I'll definitely look into switching, but see my comment in this thread as to why I'm still concerned about the behavior of terser. |
We are deprecating This issue only affects the old flow-router due to old JS patterns. |
At some point post-2.3.4, the minification process of JS files seems to have broken in some way. To reproduce, create a plain app and add
kadira:flow-router
:Then look at the minified source code:
Compare this to the actual function -- the minification seems to have dropped the last part of
doRedirect
!https://github.com/kadirahq/flow-router/blob/master/client/triggers.js#L91
The text was updated successfully, but these errors were encountered: