Work around terser bug. #11758
Merged
Work around terser bug. #11758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brianlukoff thank you for this investigation. The upgrade in the version is required to use this option or what was the reason for this bump? |
|
Just figured it was worthwhile upgrading while we were at it, but I don't think it is strictly necessary as |
filipenevola
approved these changes
Nov 12, 2021
|
I'm waiting all the tests to complete. Also, I reinstalled AppVeyor integration as it is not communicating properly with GitHub but the tests are running here. |
|
AppVeyor integration is back 🎉 |
|
Thank you @brianlukoff. This fix is published in minifier-js@2.7.2. |
|
Thanks @filipenevola! |
| @@ -22,6 +22,7 @@ export const meteorJsMinify = function (source) { | |||
| drop_debugger: false, // remove debugger; statements | |||
| unused: false, // drop unreferenced functions and variables | |||
| dead_code: true, // remove unreachable code | |||
| evaluate: false, // work around issue in terser (possibly https://github.com/terser/terser/issues/837) | |||
There was a problem hiding this comment.
This has caused #11775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix #11756, by disabling the evaluation option in terser's compressor.