-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using cordova plugins in private repos or locally #2925
Comments
This is pretty similar to inability to fetch npm modules from private GitHub repos. The main reason there, as I understand, is inability to lock on certain version by url. |
Then how about supporting pulling the directory tree of a plugin from the local filesystem? We could then figure out how to get it from the private repo to our disk ourselves (npm, whatever) edit: this is how I pulled a private repo using npm: http://stackoverflow.com/a/10391718/962223 |
We realize it is a huge pain both in development and production. We don't have a good solution right now for 1.0, we will address it later. |
So we can understand the use-case, what is your preferred means to access the code? Is it an SSH 'git@github.com...' URL? |
Honestly at this point, I'd prioritize local filesystem. The developer is then free to obtain the plugin code in whichever manner suits their workflow. |
+1 for local filesystem |
Any chance this can be looked at soon? We're developing a cordova plugin, and the only way to test it within meteor is to commit and push to a public repo. It's beyond painful. Can the regex at least be relaxed a little bit to allow filesystem access? Perhaps not enforcing the ^https? part? Paired with this, I can post an npm-based temporary solution here until you guys work out a more final solution. |
Both Justin and I are working on different projects. This issue is not prioritized. |
In the meanwhile the easiest option might be to patch Meteor as needed and On Mon, Nov 10, 2014 at 1:42 PM, Slava Kim notifications@github.com wrote:
|
+1 for using plugins from local files. It would be also cool if plugin will be re-loaded after its code is changed. |
+1 for local repo. From README of com.phonegap.plugins.facebookconnect:
And, yes, while the tarball installatiom works for this Facebook plugin case, the need to add local/private packages is still something that would arise. |
+1 |
1 similar comment
+1 |
+1 Any prediction on when this will get priority? Thanks! |
This feature was implemented in this PR: #4229 Afaik it is app-level only, but I think it is the most sane implementation. I don't think we can come up with a good semantics of a published package depending on a local plugin. |
Currently,
Cordova.depends
is hardcoded to look for a URL starting withhttp
/https
and a commit hash. I've tried to use one of our private closed-source plugins but I just can't get Meteor to play nice with it. I even resorted to using npm to install it, then tar it, stuffing the commit hash in the filename... but then the regexp ^https? messes it all up...I then tried copying it in to cordova-build-override/local-plugins/xxx but no joy since I don't have any control over that step -- I can't edit/transform files, just overwrite.
Having a local server just to host this plugin is overkill, and the build is automated and needs to work for the next person.
Anyway I'm at my wits end, I'm trying to get the client to temporarily make the repo public, but that isn't a good long-term solution.
Any thoughts?
The text was updated successfully, but these errors were encountered: