Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.1.1] Cordova meteor build iOS local plugins path bug #7804

Closed
jackkav opened this issue Sep 22, 2016 · 2 comments
Closed

[1.4.1.1] Cordova meteor build iOS local plugins path bug #7804

jackkav opened this issue Sep 22, 2016 · 2 comments

Comments

@jackkav
Copy link
Contributor

jackkav commented Sep 22, 2016

Referencing this issue #6810

During meteor build of a cordova project:
The plugin is copied into the /ios/myapp/Plugins folder then not referenced in the project.pbxproj and rather the original is referenced at a relative path given in the cordova-plugins manifest instead. I can imagine this is useful for an meteor run during plugin development. However for a meteor build this logic is incorrect. The build should copy into Plugins and then reference the copied folder.

Expected behaviour After copying local plugins into ios/myapp/Plugins folder should use that new folder reference in the project.pbxproj for the xcode build

Actual behaviour After copying local plugins into ios/myapp/Plugins folder the path used to find the plugin is used in project.pbxproj

@dmitry-sher
Copy link

Adding cordova packages from Git is immensenly slow for people in some parts of the world.. Yesterday i had to include cordova-plugin-meteor-webapp@https://github.com/meteor/cordova-plugin-meteor-webapp.git#8bf95eed3f313299fc2de33658866278eea2cdc5, because otherwise it doesn't works in Xcode 8. Now my build takes tens of minutes. It's a real pain.

image

@hwillson
Copy link
Contributor

hwillson commented Nov 2, 2017

Since there have been 7 Meteor releases since this issue was created, and there hasn't been any activity on this issue in over a year, I'll close it for now. I'm happy to re-open this issue if anyone is still encountering this problem with Meteor 1.6. Thanks!

@hwillson hwillson closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants