Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cordova plugin handling algorithm consistency improvements #10193

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Cordova plugin handling algorithm consistency improvements #10193

merged 2 commits into from
Sep 5, 2018

Commits on Sep 4, 2018

  1. Validating Cordova plugins installation (meteor#9548)

    @wojtkowiak
    zhadzlik authored and wojtkowiak committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    5558e50 View commit details
    Browse the repository at this point in the history

  2. Improvements to cordova plugin set change detection algorithm 

    Fixes several cases causing cordova plugins reinstall on every build:
- proper handling of scoped npm cordova plugins
- proper detection of plugin removal (previously a cordova plugin containing a dependency would make the algorithm think a package was removed from cordova-plugins)
- proper handling of plugins which have plugin.xml id different than the npm package name
Additionally rechecks the build integrity verifying if packages were really installed and perform a retry if needed.
Allows to override a meteor package cordova dependency with scoped package i.e. @scope/cordova-dummy-plugin will now override a cordova-dummy-plugin dependency.
    @wojtkowiak
    wojtkowiak committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    1f8ffbf View commit details
    Browse the repository at this point in the history