Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert npm-discards.js to TypeScript #10663

Open
wants to merge 9 commits into
base: release-1.8.2
from

Conversation

@jamesmillerburgess
Copy link
Contributor

commented Aug 4, 2019

This is a dependency to some other npm-related files, so doing this one first.

Remove extraneous portion of comment on discards type
This is now self-evident thanks to the typing we have done.

Also the comment was a liar anyway, because the file it referenced was
incorrect.
Add DiscardsInput type
This accommodates an undocumented, but supported syntax for NPM.strip,
in which you can pass a string/RegExp instead of an array of
string/RegExps

@benjamn benjamn force-pushed the meteor:release-1.8.2 branch 2 times, most recently from 4151c4d to 6c3ce7b Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.