Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert npm-discards.js to TypeScript #10663

merged 9 commits into from Jan 15, 2021


Copy link

@jamesmillerburgess jamesmillerburgess commented Aug 4, 2019

This is a dependency to some other npm-related files, so doing this one first.

This is now self-evident thanks to the typing we have done.

Also the comment was a liar anyway, because the file it referenced was
This accommodates an undocumented, but supported syntax for NPM.strip,
in which you can pass a string/RegExp instead of an array of
@benjamn benjamn force-pushed the release-1.8.2 branch 2 times, most recently from 4151c4d to 6c3ce7b Compare September 19, 2019 14:51
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@filipenevola Would you mind adding label:Project:TypeScript-conversion to this issue, thanks.

Copy link

@MarceloPrado MarceloPrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion looks good to me! Maybe @filipenevola could add his thoughts on the unused if branch. I don't really like the idea of supporting a syntax that's not documented or used. Maybe there's an edge case I'm not seeing?

tools/isobuild/npm-discards.ts Show resolved Hide resolved
@filipenevola filipenevola added this to the Release 2.0 milestone Oct 28, 2020
@filipenevola filipenevola added the confirmed We want to fix or implement it label Nov 5, 2020
@filipenevola filipenevola changed the base branch from release-1.8.2 to release-2.0 January 15, 2021 13:21
@filipenevola filipenevola merged commit 479c4de into meteor:release-2.0 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
confirmed We want to fix or implement it Project:TypeScript-conversion
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants