Convert npm-discards.js to TypeScript #10663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now self-evident thanks to the typing we have done. Also the comment was a liar anyway, because the file it referenced was incorrect.
This accommodates an undocumented, but supported syntax for NPM.strip, in which you can pass a string/RegExp instead of an array of string/RegExps
benjamn
force-pushed
the
release-1.8.2
branch
2 times, most recently
from
4151c4d
to
6c3ce7b
Compare
|
|
|
@filipenevola Would you mind adding label:Project:TypeScript-conversion to this issue, thanks. |
There was a problem hiding this comment.
The conversion looks good to me! Maybe @filipenevola could add his thoughts on the unused if branch. I don't really like the idea of supporting a syntax that's not documented or used. Maybe there's an edge case I'm not seeing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dependency to some other npm-related files, so doing this one first.