Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cordova to 9.0.1 #10810

Merged
merged 15 commits into from
Dec 23, 2019
Merged

Update Cordova to 9.0.1 #10810

merged 15 commits into from
Dec 23, 2019

Conversation

filipenevola
Copy link
Collaborator

@filipenevola filipenevola commented Dec 6, 2019

We want to update:

Related PRs (cordova-9 branch):
meteor/cordova-plugin-meteor-webapp#88

Related issues #10809 #10626

Follow the list of known tasks:

  • (Fixed on 1.7.1-beta.0) Don't use context.requireCordovaModule to load non-Cordova modules (error log)
  • docker images for CircleCI
    • Android 28 / Node 8
    • Android 28 / Node 12

Notes:

Make sure the following is working after the update:

  • Create a new Meteor project and add iOS and Android platforms
    • Run app on iOS simulator
    • Run app on iOS device
    • Run app on Android simulator
    • Run app on Android device

Known issues to fix:

- updates versions: this is not a working version, it is just a base to test in real application and fix issues
@filipenevola filipenevola changed the title #10809 Update Cordova to 9.0.1 Update Cordova to 9.0.1 Dec 6, 2019
@filipenevola
Copy link
Collaborator Author

Wow, I believe this is the first time cordova-plugin-meteor-webapp tests are passing build #70

At least between the ones that are still available in Travis history 😉

- uses 'cordova-plugin-meteor-webapp': '1.7.1-beta.0'
@skirunman
Copy link
Contributor

Might want to check if this is fixed in latest updates. #9293

filipenevola and others added 4 commits December 12, 2019 19:38
- updates versions: this is not a working version, it is just a base to test in real application and fix issues
- uses 'cordova-plugin-meteor-webapp': '1.7.1-beta.0'
@claassistantio
Copy link

claassistantio commented Dec 12, 2019

CLA assistant check
All committers have signed the CLA.

@filipenevola
Copy link
Collaborator Author

filipenevola commented Dec 13, 2019

I just published a new Docker image for CircleCI with Android 28 and now the checks are passing 🎉

@georgiosd
Copy link

Guys, I know you're all working for free and stuff but the broken ios simulation is breaking our hearts. Any ideas when this will get released?

@filipenevola
Copy link
Collaborator Author

hi @georgiosd our plan is to release this right after 1.9 release that is coming out soon then you should expect beta releases in the next weeks and the final release in one month or so.

But Meteor apps (AFAIK) are working in the iOS Simulator, what is the issue that you are experiencing and what Meteor version are you using?

@georgiosd
Copy link

@filipenevola hm....

#10673
#10745

Some people seem able to run with an old Xcode version. I tried 10.3 and I still had the aforementioned problems.

I only managed to make it work after several hours by upgrading ios-sim in the cordova directory and monkey patching the devices list JS file.

@renanccastro
Copy link
Contributor

@filipenevola hm....

#10673
#10745

Some people seem able to run with an old Xcode version. I tried 10.3 and I still had the aforementioned problems.

I only managed to make it work after several hours by upgrading ios-sim in the cordova directory and monkey patching the devices list JS file.

@georgiosd You are right, in the current version we have a bug with the command meteor run ios that is fixed with this PR. This command opens the ios simulator directly.

In the meantime, you can open the xcode with meteor run ios-device and press play on it, it will run the simulator in the same way with newest xcode. I'm running with 11.3, for example. This is what works the best for running ios apps and is future proof. If you have any problems, let me know and I can help you.

@georgiosd
Copy link

@renanccastro I managed to patch the problem, lmk if instructions on how to do that would be of use to anyone over there

@filipenevola filipenevola added this to the Release 1.8.4 milestone Dec 23, 2019
@filipenevola filipenevola removed the wip label Dec 23, 2019
@filipenevola filipenevola changed the base branch from devel to release-1.8.4 December 23, 2019 17:44
@filipenevola filipenevola merged commit 8e1c77e into release-1.8.4 Dec 23, 2019
@filipenevola filipenevola deleted the cordova-9 branch December 23, 2019 17:45
@benjamn benjamn restored the cordova-9 branch January 13, 2020 15:46
filipenevola added a commit that referenced this pull request Jan 13, 2020
Rebase PR #10810 (Cordova 9) against current devel branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants