Allow to exclude web architectures in development mode #10824

sebakerckhof · 2019-12-18T11:21:25Z

This commit implements an --exclude-archs arg to the run command which allows you to pass a comma-seperated list of architectures to exclude.

Motivation:
Improve rebuild speeds, by allowing to leave out certain web architectures during development.

Meteor rebuild speeds, although greatly improved in recent versions, is still a common point of frustration as seen in the issues (#10800) and on the forum (https://forums.meteor.com/t/2x-to-3x-longer-build-time-also-on-testing-since-1-8-2-update/51028/3)

One reason for slow rebuilds is high memory pressure (#9568).
The web.browser.legacy architecture is currently always being build while most of us will only test this every once in a while.
So while we don't need it most of times during development it does add to the high memory usage.
Furthermore, even though these builds are delayed, long-running synchronous tasks have the potential to block the server startup (#10261).
This last issue can be partially, but not fully, improved by #10427
Therefore a commonly requested feature has been to disable the legacy build (meteor/meteor-feature-requests#333)

However, we may also temporarily disable cordova builds and we may even want to disable just the web.browser build if we're just debugging a bug in the legacy build.
Therefore I chose to create the more generic --exclude-archs option.

sebakerckhof · 2019-12-18T11:25:22Z

ping @veered

filipenevola

Great work! thanks

RobertLowe · 2019-12-20T02:20:15Z

any METEOR_PROFILE=1s to compare?

sebakerckhof · 2019-12-20T13:31:18Z

@RobertLowe Here's 2 profiles from a cold start:

182-standard-cold.txt
182-nolegacy-cold.txt

During development/rebuilds it's using 1/3rd less memory (about 1gb for our application). In case you're low on RAM, this will help for rebuild times as well.

RobertLowe · 2019-12-20T14:19:51Z

@sebakerckhof nice, I see about 100s saved build time, very nice! Curious, did you clean build caches between?

sebakerckhof · 2019-12-20T15:07:46Z

@RobertLowe yes both were after a meteor rebuild which clears the caches.
Anyway, the metric for a cold boot isn't very interesting IMO, since you don't do that often. I'm way more interested in rebuild times. And although the legacy rebuild is delayed, the additional memory usage for the legacy build can really slow down the modern rebuild if you're short on memory.

RobertLowe · 2019-12-20T17:13:11Z

@sebakerckhof it's still a welcome improvement!! Thanks for getting this out there, thanks @benjamn for targeting this for 1.8.4!! 👍 🎉

hexsprite · 2020-01-02T20:31:16Z

Will this work for running tests as well? I noticed that they can also build archs that I don't care about...

sebakerckhof · 2020-01-07T11:48:18Z

@hexsprite I've added the option for tests as well. Should also address #10690

sebakerckhof · 2020-01-07T14:40:08Z

Btw, currently this will crash if you do something like:
meteor run android --exclude-archs web.cordova
Because well, this doesn't make much sense, so we can handle it in multiple ways:

Ignore the exclude archs for web.cordova
Don't start the cordova runner, just start the server
Throw an error saying this combination is invalid

Any preferences to what seem best?

hexsprite · 2020-01-07T17:15:29Z

testing this out when running tests. sure makes a huge difference in build times and memory pressure as you say!

benjamn

This looks great to me!

@sebakerckhof Can you rebase against devel? I think this might make more sense for a Meteor 1.9.1 release, now that Meteor 1.9 has been finalized.

RobertLowe · 2020-01-10T23:11:29Z

@benjamn 1.9.1-rc.0 eta? 😛 this feature is significantly helpful

This commit implements an --exclude-archs arg to the run command which allows you to pass a comma-seperated list of architectures to exclude. Motivation: Improve rebuild speeds, by allowing to leave out certain web architectures during development. Meteor rebuild speeds, although greatly improved in recent versions, is still a common point of frustration as seen in the issues (meteor#10800) and on the forum (https://forums.meteor.com/t/2x-to-3x-longer-build-time-also-on-testing-since-1-8-2-update/51028/3) One reason for slow rebuilds is high memory pressure (meteor#9568). The web.browser.legacy architecture is currently always being build while most of us will only test this every once in a while. So while we don't need it most of times during development it does add to the high memory usage. Furthermore, even though these builds are delayed, long-running synchronous tasks have the potential to block the server startup (meteor#10261). This last issue can be partially, but not fully, improved by meteor#10427 Therefore a commonly requested feature has been to disable the legacy build (meteor/meteor-feature-requests#333) However, we may also temporarily disable cordova builds and we may even want to disable just the web.browser build if we're just debugging a bug in the legacy build. Therefore I chose to create the more generic --exclude-archs option.

We accidentally published changes to webapp that should have been restricted to Meteor 1.10 as part of the 1.8.1 version. This commit reverts commits to packages/webapp since Meteor 1.9, so that we can republish the 1.8.0 content as version 1.8.2. We will then bump the webapp version to 1.9.0 on the release-1.10 branch and publish the new content only on that branch. Revert "Allow to exclude web architectures in development mode (#10824)" This reverts commit a205967. Revert "Updates cordova-plugin-meteor-webapp to 1.7.1" This reverts commit a1e4d27. Revert "Update cordova-plugin-wkwebview-engine to 1.2.1." This reverts commit 3f9a69d. Revert "Update cordova-plugin-whitelist to 1.3.4." This reverts commit 9792733. Revert "Update cordova-plugin-meteor-webapp to 1.7.1-beta.1." This reverts commit 565c425. Revert "Update accounts-password to version 1.5.2." This reverts commit b827d1d.

Follow-up to #10824. If the preferred arch is not available (most likely because it was deliberately excluded), it's better to use another client arch that is available than to guarantee the site won't work by returning an unknown arch. For example, if web.browser.legacy is excluded using the --exclude-archs option (introduced by #10824), legacy clients are better served by receiving web.browser (which might actually work) than receiving an HTTP 404 response. If none of the arches in preferredArchOrder are defined, only then should we send a 404.

dosomder · 2020-04-07T08:33:49Z

@sebakerckhof Why only for run / test? Would be useful to disable legacy with build too

sebakerckhof requested a review from benjamn December 18, 2019 11:21

sebakerckhof force-pushed the feat/exclude-webarchs branch from 8753bfa to 5f7f3c3 Compare December 18, 2019 11:25

filipenevola approved these changes Dec 19, 2019

View reviewed changes

benjamn added this to the Release 1.8.4 milestone Dec 19, 2019

StorytellerCZ mentioned this pull request Dec 20, 2019

Allow a switch to disable building of the legacy bundle meteor/meteor-feature-requests#333

Closed

filipenevola mentioned this pull request Dec 23, 2019

[1.7.0.1] Optionally disable web.browser/web.browser.legacy in development #9948

Closed

filipenevola changed the base branch from devel to release-1.8.4 December 23, 2019 17:38

nachocodoner mentioned this pull request Jan 2, 2020

Release 1.8.2 #10522

Merged

sebakerckhof mentioned this pull request Jan 6, 2020

TEST_CLIENT=0 will still build client and refresh #10690

Closed

benjamn approved these changes Jan 10, 2020

View reviewed changes

sebakerckhof force-pushed the feat/exclude-webarchs branch from 1474c8b to 03605dc Compare January 13, 2020 12:36

sebakerckhof changed the base branch from release-1.8.4 to devel January 13, 2020 12:37

benjamn force-pushed the feat/exclude-webarchs branch from 03605dc to 2157f39 Compare January 13, 2020 20:39

sebakerckhof and others added 3 commits January 13, 2020 15:49

Version bumps for appcache and webapp packages.

ac47b73

Move History.md note about --exclude-archs up to v1.10.

54b6803

benjamn force-pushed the feat/exclude-webarchs branch from 2157f39 to 54b6803 Compare January 13, 2020 20:52

benjamn modified the milestones: Release 1.8.4, Release 1.10 Jan 13, 2020

benjamn merged commit a205967 into meteor:devel Jan 13, 2020

benjamn mentioned this pull request Jan 14, 2020

Release 1.10 #10861

Merged

5 tasks

afrokick mentioned this pull request Feb 2, 2020

[WIP] Allow interrupting delayed builds. #10427

Closed

SimonSimCity mentioned this pull request Mar 11, 2020

Allow to exclude web architectures in every mode meteor/meteor-feature-requests#389

Open

benjamn mentioned this pull request Mar 30, 2020

Try other web.* arches if preferred arch was excluded. #10994

Merged

filipenevola mentioned this pull request May 17, 2021

Document --exclude-archs flag meteor/docs#721

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to exclude web architectures in development mode #10824

Allow to exclude web architectures in development mode #10824

sebakerckhof commented Dec 18, 2019

sebakerckhof commented Dec 18, 2019

filipenevola left a comment

RobertLowe commented Dec 20, 2019

sebakerckhof commented Dec 20, 2019

RobertLowe commented Dec 20, 2019

sebakerckhof commented Dec 20, 2019

RobertLowe commented Dec 20, 2019

hexsprite commented Jan 2, 2020

sebakerckhof commented Jan 7, 2020

sebakerckhof commented Jan 7, 2020

hexsprite commented Jan 7, 2020

benjamn left a comment

RobertLowe commented Jan 10, 2020

dosomder commented Apr 7, 2020

Allow to exclude web architectures in development mode #10824

Allow to exclude web architectures in development mode #10824

Conversation

sebakerckhof commented Dec 18, 2019

sebakerckhof commented Dec 18, 2019

filipenevola left a comment

Choose a reason for hiding this comment

RobertLowe commented Dec 20, 2019

sebakerckhof commented Dec 20, 2019

RobertLowe commented Dec 20, 2019

sebakerckhof commented Dec 20, 2019

RobertLowe commented Dec 20, 2019

hexsprite commented Jan 2, 2020

sebakerckhof commented Jan 7, 2020

sebakerckhof commented Jan 7, 2020

hexsprite commented Jan 7, 2020

benjamn left a comment

Choose a reason for hiding this comment

RobertLowe commented Jan 10, 2020

dosomder commented Apr 7, 2020