Add platforms options to meteor build: #11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the "--platforms" flag to meteor build command. This allows the user to specify which platforms he want to build and build it only. For example, if we pass only android to it, we will build only android and web.cordova. Related to issue meteor#63 (meteor/meteor-feature-requests#63)
|
|
renanccastro
approved these changes
May 17, 2021
StorytellerCZ
approved these changes
May 17, 2021
matheusccastroo
added a commit
to matheusccastroo/docs
that referenced
this pull request
May 17, 2021
|
@renanccastro @StorytellerCZ PR for documentation created: meteor/docs#720 |
filipenevola
requested changes
May 17, 2021
| @@ -1014,6 +1015,19 @@ var buildCommand = function (options) { | |||
| // _bundleOnly implies serverOnly | |||
| const serverOnly = options._bundleOnly || !!options['server-only']; | |||
|
|
|||
| let selectedPlatforms; | |||
There was a problem hiding this comment.
It's better to initialize with null
| const filteredArchs = projectContext.platformList.getWebArchs().filter((arch) => selectedPlatforms.includes(arch)); | ||
|
|
||
| if (! _.isEmpty(cordovaPlatforms)) { | ||
| if (filteredArchs.indexOf("web.cordova") < 0) { |
There was a problem hiding this comment.
It should be includes instead of indexOf
@filipenevola Not really, I was just following what was here #7144. However, thinking again, I think |
|
I did small changes here 839a69d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the "--platforms" flag to meteor build command. This allows the user to specify which platforms he want to build. For example, if we pass only android to it, we will build only android and web.cordova.
I think this is pretty useful when we want to build a specific mobile app. For example, I want to build only for android and not for iOS (but I may still build for iOS on another time, so removing and adding the platform is more work to do).
Usage example:
meteor build . --platforms=android.Note: if no platforms flag is used, it will do the build like it always did.
Related to issue #63 (meteor/meteor-feature-requests#63)