-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tar library for faster extractions/compressions #11841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem to be too easy. I think there was some issue when I have attempted this months ago. 🤔 Or it might have been reversed due to a bigger reversal or it was deemed as not necessary at that time. Still, glad that this is finally being bumped.
…for manipulating tar streams
…for manipulating tar streams
…for manipulating tar streams
@StorytellerCZ it was still a WIP when you reviewed :) From my tests, deploys are at least 30% faster when using tar-fs compared to the version of tar we were using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@renanccastro well done! |
This PR updates the tar library for faster extractions/compressions.
We are now using tar-fs and tar-streams, as they are 10x faster working with tar streams compared to the version we had of tar.
https://www.npmjs.com/package/tar-fs#performance
Testing locally, I've been able to see a reduction of 30% on deploy time(in the upload bundle step)