Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tar library for faster extractions/compressions #11841

Merged
merged 6 commits into from
Jan 11, 2022

Conversation

renanccastro
Copy link
Contributor

@renanccastro renanccastro commented Jan 7, 2022

This PR updates the tar library for faster extractions/compressions.

We are now using tar-fs and tar-streams, as they are 10x faster working with tar streams compared to the version we had of tar.

https://www.npmjs.com/package/tar-fs#performance

Testing locally, I've been able to see a reduction of 30% on deploy time(in the upload bundle step)

Copy link
Collaborator

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to be too easy. I think there was some issue when I have attempted this months ago. 🤔 Or it might have been reversed due to a bigger reversal or it was deemed as not necessary at that time. Still, glad that this is finally being bumped.

@renanccastro renanccastro added the in-development We are already working on it label Jan 10, 2022
@renanccastro
Copy link
Contributor Author

@StorytellerCZ it was still a WIP when you reviewed :)


From my tests, deploys are at least 30% faster when using tar-fs compared to the version of tar we were using.

@renanccastro renanccastro added this to the Release 2.5.4 milestone Jan 11, 2022
@renanccastro renanccastro changed the base branch from devel to release-2.5.4 January 11, 2022 20:38
@renanccastro renanccastro merged commit 62fcdb3 into release-2.5.4 Jan 11, 2022
Copy link
Collaborator

@filipenevola filipenevola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StorytellerCZ
Copy link
Collaborator

@renanccastro well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants