chore: resetPassword and verifyEmail to no longer sign in the user automatically #12385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sign in the user automatically if they have 2fa enabled
|
I consider this to be a breaking change. Is that a fair statement? Maybe we should apply this by default but give the developer the option to disable this behavior? |
I do think the same. But at the same, I think it may be a thing to go in a patch because it sounds like a security improvement |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the methods
resetPassword()andverifyEmail()to no longer sign in the user automatically if they have 2fa enabled.By default these methods already work has the 2FA, sort of speaking, because you need to have access to the user's email in order to finish the operation.
This PR just adds one more layer to that.