[3.x] Fix promise rejection throwing several times

[nachocodoner]

OSS-322

Context: #12950

I have given a reattempt to this issue. And after studying more the code and the experience so far about it I came up with the proper fix.

Within Meteor 3.x code, there are three promises utilized when invoking methods: promise for server promises, stubPromise for client simulation, and serverPromise, which acts as a wrapper for promise.
Refer here to understand further 2.x and 3.x async behaviors.

In the Meteor 3.x codebase, we encounter several layers where promises are nested. In JavaScript, when promises are nested, unhandled exceptions from the "child" promises propagate upwards to the parent or root, resulting in uncaught errors. I've identified these instances and provided solutions for them.

Reproduction

Described a method that always throw an error on client and server side.

Meteor.methods({  
    promiseRejectionSeveralLogs: async function() {  
       throw new Meteor.Error('negative')  
    },  
});

Then on the client side I run callAsync it and manage the promises

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);

if (promise.stubPromise)  
    promise.stubPromise.catch(e => console.error('stubPromise error', e));
  
if (promise.serverPromise)  
    promise.serverPromise.catch(e => console.error('serverPromise error', e)); 
 
if (promise)  
    promise.catch(e => console.error('promise error', e));

I have seen other scenarios where even more uncaught promises are showing as described on this issue, #12950

Fix

promise + stubPromise + serverPromise

With the changes on this PR.

promise

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);
if (promise)  
    promise.catch(e => console.error('promise error', e));

promise + stubPromise

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);
if (promise.stubPromise)
    promise.stubPromise.catch(e => console.error('stubPromise error', e));
if (promise)
    promise.catch(e => console.error('promise error', e));

promise + serverPromise

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);
if (promise.serverPromise)
    promise.serverPromise.catch(e => console.error('serverPromise error', e));
if (promise)
    promise.catch(e => console.error('promise error', e));

stubPromise

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);
if (promise.stubPromise)
    promise.stubPromise.catch(e => console.error('stubPromise error', e));

serverPromise

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);
if (promise.serverPromise)
    promise.serverPromise.catch(e => console.error('serverPromise error', e));

serverPromise + stubPromise

const promise = Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);
if (promise.stubPromise)
    promise.stubPromise.catch(e => console.error('stubPromise error', e));
if (promise.serverPromise)
    promise.serverPromise.catch(e => console.error('serverPromise error', e));

no promise caught

await Meteor.callAsync('promiseRejectionSeveralLogs', ['thing']);

[netlify]

✅ Deploy Preview for v3-meteor-api-docs canceled.

Name	Link
🔨 Latest commit	fa94abb
🔍 Latest deploy log	https://app.netlify.com/sites/v3-meteor-api-docs/deploys/66044fcd207ff6000806200e