A trivial way to implement Npm.resolve for #845 #1353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to current |
Slava
force-pushed
the
devel
branch
2 times, most recently
from
e5104bf
to
81565b1
Compare
|
Thanks for the feature request! We welcome discussions about how to make Meteor better. If you haven't yet, check out our wiki page about feature requests on GitHub. (This PR has gotten unmergeable again.) |
|
I am also not sure anymore how this interacts with building and deploying. I think a better way would be now that you could add assets from NPM packages into an isopackage. Both on client and server. Something I described in #3642. So there is some design decision here needed, how to address all this questions. |
|
This is really old now. |
|
Ha just started to go through those - thank @mitar for updating |
|
Personally I still think that this would be useful, but at least I do not have use for it at the moment anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #845 to add
require.resolvetoNpm. The idea is that sometimes you have to have access to files bundled in npm packages and not import them as node.js modules.(Updated version of #1188 against current
develbranch.)