Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$regex throws incorrect error with an empty string argument #1874

Closed
wants to merge 10 commits into from
Closed

$regex throws incorrect error with an empty string argument #1874

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3ad64c
Update dependencies for madewith package; fixes #1448
mizzao Sep 25, 2013
dff9475
Merge remote-tracking branch 'upstream/devel' into madewith-fix
mizzao Sep 25, 2013
a05b458
Merge remote-tracking branch 'upstream/master' into devel
mizzao Dec 3, 2013
1c33254
Merge remote-tracking branch 'upstream/devel' into devel
mizzao Dec 19, 2013
b60b16e
Merge branch 'devel' of github.com:mizzao/meteor into devel
mizzao Jan 23, 2014
2828e03
Merge branch 'devel' of github.com:meteor/meteor into devel
mizzao Feb 3, 2014
256bca0
Merge remote-tracking branch 'upstream/devel' into devel
mizzao Feb 13, 2014
360f812
Merge remote-tracking branch 'origin/devel' into devel
mizzao Feb 13, 2014
ba9e210
Merge branch 'devel' of github.com:meteor/meteor into devel
mizzao Feb 28, 2014
a90fac9
fix regex selector for empty string
mizzao Feb 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/minimongo/selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ var VALUE_OPERATORS = {
},
// $options just provides options for $regex; its logic is inside $regex
$options: function (operand, valueSelector) {
if (!valueSelector.$regex)
if (!valueSelector.hasOwnProperty("$regex"))
throw Error("$options needs a $regex");
return everythingMatcher;
},
Expand Down