-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to error reporting in Tracker. #3822
Conversation
The onError callback doesn't actually help fix #3822, does it? Or would it help because you can |
The logging part does help. It just occurred to me, this change might "break" some tests as the code doesn't use Meteor._debug anymore. |
* @returns {Tracker.Computation} | ||
*/ | ||
Tracker.autorun = function (f) { | ||
Tracker.autorun = function (f, onError) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since most users of Tracker.autorun
(a very user-visible API) won't use this optional feature, it should probably be a named option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
@Slava ping! |
- Allow passing an onError callback to Tracker.autorun. - Workaround the issue described in #3655 by logging parts of error message separately.
ping :) |
LGTM |
Yay, merged to release 1.1 branch (cc @philcockfield) |
👍 |
separately.
Attempts to fix #3655