Address issue #4973 #4908
Closed
Address issue #4973 #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround a race condition occuring in Tracker.Dependency.prototype.changed function
|
Can you add a test case for this? |
|
@glasser I think we may give you access to one of Knotable projects (Knoteup) where we've seen this effect and after applying the patch it's gone. cc @angusmcleod |
|
@eluck I don't think that will help. One of the main reasons we need tests for stuff like this is so that we don't accidentally break it in the future. |
|
@stubailo Looks like it was the browser issue as it's not the case any more. |
|
Thanks for this PR, and sorry we never got around to merging it. We are currently cleaning up the repository and removing old PRs; if you think this PR still has value and are interested in resurrecting it, we encourage you to re-submit it against current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround a race condition occuring in Tracker.Dependency.prototype.changed function
Analysis can be found here: #4793