Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oauth refresh token #495

Closed
wants to merge 26 commits into from
Closed

Oauth refresh token #495

wants to merge 26 commits into from

Conversation

scottburch
Copy link

Provides a http wrapper to automatically refresh oauth token if necessary to make a request.

nwmartin and others added 26 commits November 1, 2012 17:50
@nwmartin
Ignoring .iml's.
ed8ee89
@nwmartin
Automatic online access types.
0fb3746
@nwmartin
Ignoring sublime text project files.
f46dd1b
@nwmartin
Checking for offline/online in config.
3415308
@nwmartin
;
5463eba
@nwmartin
; + gitignore.
d4126cd
@nwmartin
Committing refresh stuff for tomorrow.
07dad0c
@nwmartin
Merge github.com:RiparianData/meteor into google-offline
d4b0055 
Conflicts:
	.gitignore
	packages/accounts-google/google_client.js
@nwmartin
Merge branch 'google-offline' of github.com:RiparianData/meteor into …
f41eeff 
…google-offline

Conflicts:
	packages/accounts-google/google_client.js
@nwmartin
Providing an access type on config.
47d3420
@nwmartin
Now preserving refresh tokens past login/logout.
b2dc77c
@n1mmy
Merge branch 'version-bump' into devel
26ce169
@n1mmy
Basic benchmark app. Very unfinished.
42fa76c
@n1mmy
Comment on dependencies in license file.
0619101
@n1mmy
Bump version number to 0.5.1.
83386b2
@glasser
Notes for 0.5.1 History.md. Needs to be turned into English.
56f66e8
@glasser
First draft of release notes for 0.5.1.
3f17883
@glasser
Release notes improvements.
6c19b05
@glasser
Improve test isolation in livedata_tests.
e93e35c
@avital
accounts-ui fixes related to the introduction of {{loggingIn}}
646b357 
- Correctly position certain elements
- Reduce flicker/things moving around in various cases
- Force dropdown to open in case there is a message to display
@glasser
Clean up History.md for 0.5.1.
1eec537
@glasser
Fix bug where half-completed wait methods could block future method e…
c1c1fd9 
…xecution.
@scottburch
Merge branch 'google-offline' of git://github.com/RiparianData/meteor…
f3d4907 
… into conDingo
@nwmartin
Removing superfluous return.
949628f
@scottburch
Merge branch 'google-offline' of git://github.com/RiparianData/meteor…
37a52f0 
… into conDingo
@scottburch
http wrapper to automatically refresh token when talking to google
f75c9c6
@scottburch
Copy link
Author

This branch is off of google-offline. this is the first time I have used pull-request on github.

This code may not belong in the auth code. I was not sure. It is a bit of mixing concerns. I put it here since it refreshes the token, but it's main function is not auth. Let me know what you think. I am happy to move it to it's own package since it is not really an auth function.

@avital
Copy link
Contributor

avital commented Nov 20, 2012

This Pull Request contains many commits that are unrelated. Could you please recreate it, against the devel branch (rather than master) and make sure it only contains your commits? You may have merged branches into your oauth-refresh-token. If so, you should probably have used rebase instead, but for now you might just want to re-apply your changes onto a fresh branch off of devel. One way to do it is:

  1. Make sure all of your branches are up-to-date
  2. Go to your oauth-refresh-token branch
  3. git reset devel (this will put all of your changes back in to the working copy, in the uncommitted state)
  4. git checkout -b oauth-refresh-token-take2
  5. git commit -a

@avital avital mentioned this pull request Nov 20, 2012
Closed
@scottburch
Copy link
Author

I thought that might be an issue. I went off of your release 0.5.1 branch. Will do right away.

@scottburch
Copy link
Author

One thing. This requires the google offline PR as well. I can stack mine on top of those commits and place them here. Or would you rather pull that one first?

@avital
Copy link
Contributor

avital commented Nov 20, 2012

Good question. If this diff is dependant on the other please make both
changes on this PR.

I'll review them all together.

Does this mean the other offline PR can be closed or are there important
other comments there?
On Nov 20, 2012 11:46 AM, "Scott Burch" notifications@github.com wrote:

One thing. This requires the google offline PR as well. I can stack mine
on top of those commits and place them here. Or would you rather pull that
one first?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/495#issuecomment-10569759.

@scottburch
Copy link
Author

I will leave a note there. I will ensure that I fetch all commits and include them in this PR.

@avital avital mentioned this pull request Dec 4, 2012
Closed
@avital
Copy link
Contributor

avital commented Dec 4, 2012

Now that #464 is merged to devel, we can pick up on this. @scottburch, could you please recreate this PR against devel (rather than master), with the minimal changes needed now that we support offline tokens for Google?

Sorry if this process has been confusing. I was less organized than I usually like to be.

Thanks a lot!

@scottburch
Copy link
Author

Not confusing at all. Makes perfect sense. I have already cherry-picked it on your branch for testing. I have not completed that yet. When I have, I will rebase onto devel and send a pull request

@avital
Copy link
Contributor

avital commented Dec 4, 2012

Thanks!

@avital
Copy link
Contributor

avital commented Dec 4, 2012

(Just a note, my branch is gone now. All work should be done against devel.)

@scottburch
Copy link
Author

#522 is the new pull request

@avital
Copy link
Contributor

avital commented Dec 4, 2012

And this one is no longer relevant, correct? (closing, reopen if I am wrong)

@avital avital closed this Dec 4, 2012
@scottburch
Copy link
Author

@avital Right, this one is old.

@joscha joscha mentioned this pull request Dec 5, 2012
Closed
StorytellerCZ pushed a commit that referenced this pull request Sep 18, 2021
@dferber90
Merge pull request #495 from dferber90/greenkeeper/mocha-3.4.2
bd0a003 
Update mocha to the latest version 🚀
StorytellerCZ pushed a commit that referenced this pull request Oct 1, 2021
@JWPapi @lorensr
Remove Reapp recommendation (#495)
a95cec9 
Reapp is not maintained good, I would not recommend it. Even there demo is off for 30 days

https://github.com/reapp/reapp/issues/119
StorytellerCZ pushed a commit that referenced this pull request Oct 1, 2021
@lorensr
Give component library option for mobile React #495
cef1a9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scottburch @avital @nwmartin @n1mmy @glasser