Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose makeAttributeHandler #5893

Closed
wants to merge 1 commit into from
Closed

Expose makeAttributeHandler #5893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/blaze/attrs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ AttributeHandler.extend = function (options) {
//
// Extended below to support classes, SVG elements and styles.

var DiffingAttributeHandler = AttributeHandler.extend({
Blaze._DiffingAttributeHandler = AttributeHandler.extend({
update: function (element, oldValue, value) {
if (!this.getCurrentValue || !this.setValue || !this.parseValue)
throw new Error("Missing methods in subclass of 'DiffingAttributeHandler'");
Expand All @@ -91,7 +91,7 @@ var DiffingAttributeHandler = AttributeHandler.extend({
}
});

var ClassHandler = DiffingAttributeHandler.extend({
var ClassHandler = Blaze._DiffingAttributeHandler.extend({
// @param rawValue {String}
getCurrentValue: function (element) {
return element.className;
Expand Down Expand Up @@ -119,7 +119,7 @@ var SVGClassHandler = ClassHandler.extend({
}
});

var StyleHandler = DiffingAttributeHandler.extend({
var StyleHandler = Blaze._DiffingAttributeHandler.extend({
getCurrentValue: function (element) {
return element.getAttribute('style');
},
Expand Down Expand Up @@ -281,7 +281,7 @@ var UrlHandler = AttributeHandler.extend({
});

// XXX make it possible for users to register attribute handlers!
makeAttributeHandler = function (elem, name, value) {
Blaze._makeAttributeHandler = function (elem, name, value) {
// generally, use setAttribute but certain attributes need to be set
// by directly setting a JavaScript property on the DOM element.
if (name === 'class') {
Expand Down Expand Up @@ -346,7 +346,7 @@ ElementAttributesUpdater.prototype.update = function(newAttrs) {
if (! _.has(handlers, k)) {
if (value !== null) {
// make new handler
handler = makeAttributeHandler(elem, k, value);
handler = Blaze._makeAttributeHandler(elem, k, value);
handlers[k] = handler;
oldValue = null;
}
Expand Down