Clone serverWatchSet to not modify it

[mitar]

Otherwise settingsWatchSet is added to bundleResult.serverWatchSet which is at the same also cachedServerWatchSet.

Also a fix for style.

[mitar]

Ping.

[benjamn]

This seems to interfere with the assumptions of this code below:

if (! canRefreshClient) {
  // Restart server on client changes if we can't refresh the client.
  serverWatchSet = combinedWatchSetForBundleResult(bundleResult);
}

Specifically, if ! canRefreshClient, we throw away the cloned serverWatchSet you created above, which effectively discards the settingsWatchSet files you added to it.

Does that make sense? Is that cause for concern?

[mitar]

Maybe then serverWatchSet.merge(settingsWatchSet); should be called after ! canRefreshClient.

So what worries me is that you modify something which I see as input (serverWatchSet) internally.

But probably it does not matter. Feel free to close this pull request.

[stubailo]

But probably it does not matter. Feel free to close this pull request.

Doing this.