Use tokens from Google Sign-In instead of calling getTokens. #8604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged this and released |
This was referenced Apr 14, 2017
|
@benjamn Hmm, strange, |
abernix
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Use tokens from Google Sign-In instead of calling getTokens. Follow-up to #8588. * Bump google-oauth package version to 1.2.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8588.
While testing #8588, I noticed that
request.serverAuthCodewas sometimes/always an empty string (on iOS, at least), so thequerythat was passed togetServiceDatadidn't have a usable.codeproperty.I then realized that the response from Google Sign-In already contains the tokens that would be returned from
getTokens, so this PR avoids callinggetTokensin that case, though it still shares most of theserviceDatalogic.cc @realyze @ramezrafla @abernix