/meteor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Facebook api version in loginUrl #8858

Merged
merged 3 commits into from Jun 30, 2017

Conversation

Reviewers
No reviews
Assignees

@abernix abernix

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hasantayyar @meteor-bot @abernix
@hasantayyar
Contributor

hasantayyar commented Jun 29, 2017

The most recent version of the API is Version 2.9, which was introduced on April 18th, 2017 https://developers.facebook.com/docs/apps/changelog

The url parameters are not changed with the new version https://developers.facebook.com/docs/facebook-login/manually-build-a-login-flow

Fixes #8856
@hasantayyar
Update Facebook api version in loginUrl 
The most recent version of the API is Version 2.9, which was introduced on April 18th, 2017 https://developers.facebook.com/docs/apps/changelog
Loading status checks…
3096dac
@meteor-bot

This comment has been minimized.

Sign in to view

meteor-bot commented Jun 29, 2017

@hasantayyar: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@hasantayyar hasantayyar changed the base branch from master to devel Jun 29, 2017

@abernix abernix self-assigned this Jun 29, 2017

abernix added some commits Jun 30, 2017

@abernix
Bump `facebook-oauth` version in preparation for publishing. 
For #8858.
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
d72c55f
@abernix
Bump `accounts-facebook` version in preparation for publishing. 
As a required bump for `facebook-oauth` dependency bump in
6f92ae9838b19914016e8c77a976d006279fc0b9 for
#8858.
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
Loading status checks…
384e3a5

@abernix abernix changed the base branch from devel to master Jun 30, 2017

@abernix abernix merged commit d97c916 into meteor:master Jun 30, 2017
3 checks passed

3 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abernix

This comment has been minimized.

Sign in to view
Member

abernix commented Jun 30, 2017

Thanks for submitting this! I've published a new facebook-oauth@1.3.2 and a accounts-facebook@1.2.1 (which depends on it) with this change, bringing the Facebook Graph API to v2.9 for the login dialog.

abernix added a commit that referenced this pull request Jun 30, 2017

@abernix
Add `History.md` entry for #8858.
Verified
This commit was signed with a verified signature.
@abernix abernix Jesse Rosenberger
GPG key ID: C0CCCF81AA6C08D8 Learn about signing commits
Loading status checks…
684ac9c

@hwillson hwillson referenced this pull request Jun 30, 2017

Closed

Upgrade Facebook Graph API version #8856

@hasantayyar hasantayyar deleted the hasantayyar:patch-1 branch Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment