Be more considerate of interactive environments and expired tokens. #9015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a login token is expired, or no longer valid, make sure that Meteor doesn't just sit there at a login prompt that the user can't see. This currently only applies if `headless` mode is enabled, though a follow-up to this commit might consider setting `headless = true` automatically in a CI environment using environment variables such as: `CI`, `TRAVIS`, `JENKINS_URL`, etc., as the npm-registry-client does in a similar way. See: https://github.com/npm/npm-registry-client/pull/129/files Fixes #8839.
hwillson
approved these changes
Aug 15, 2017
benjamn
approved these changes
Aug 15, 2017
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a login token is expired, or no longer valid, make sure that Meteor doesn't
just sit there at a login prompt that the user can't see.
This currently only applies if
headlessmode is enabled, though a follow-upto this commit might consider setting
headless = trueautomaticallyin a CI environment using environment variables such as:
CI,TRAVIS,JENKINS_URL, etc., as the npm-registry-client does in a similar way.See: https://github.com/npm/npm-registry-client/pull/129/files
Fixes #8839.