Changes to npm installation methods for npm@5 / Meteor 1.6. #9021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing problems with `npm@5`, but realistically it may not be be necessary anymore since `npm@5` has a much smarter global, self-healing `cacache`.
The `child_process` documentation indicates that .cmd scripts (such as the `npm.cmd` script for npm) must be started within a shell, such as cmd.exe. While it was tempting to switch this to use `child_process`'s `spawn`, which supports a `shell` option, it would have required us to buffer our own stdout/stderr output via `data` event handlers. Ref: https://nodejs.org/api/child_process.html#child_process_spawning_bat_and_cmd_files_on_windows
benjamn
approved these changes
Aug 16, 2017
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR submits two changes for the
release-1.6branch (Meteor 1.6) which usesnpm@5. Without this fix, on Windows 10 Insider Preview, somewhat cryptic errors were encountered when trying tometeor npm install, such as:This appears to be fixed if we no longer set the
NPM_CONFIG_CACHEvariable to our own cache directory. This should be fine given thatnpm@5has much more robust, self-healing, concurrency-toutingcacacheimplementation. This should help reduce the amount of disk space by allowing Meteor to use your global npm cache (e.g.~/.npm,%APPDATA%\npm) instead of its own within the dev bundle.Additionally, as there are now some more official recommendations on how to launch
.cmdand.bat(i.e. Windows) scripts in the docs, this also changes the way we spawnnpm installinternally (such as when we build npms for packages, or when we install the default skeleton set of npms withmeteor create <app>to launch thenpm.cmdusingcmd.exeas prescribed. Without this change,meteor create <app>was not working for me with1.6-beta.20.